search

qawolf / playwright-video

🎬 Save a video of a Playwright page
BSD 3-Clause "New" or "Revised" License
194 stars 17 forks source link

Q: Compatibility issue with playwright 1.4? #135

Closed mortelee closed 4 years ago

mortelee commented 4 years ago

Hi

I'm creating UI tests using playwright 1.4 and use your awesome playwright-video package to capture the results of the UI test. When I call saveVideo I see some typescript error in my editor. I'm not sure if this is because of using playwright 1.4. Never hurts to ask ;)

image

jperl commented 4 years ago

@mortelee We are probably going to deprecate this package since Playwright is adding native video recording support. You can try it out in playwright 1.4 https://playwright.dev/#version=v1.4.0&path=docs%2Fapi.md&q=browsertypelaunchoptions--options-videospath

mortelee commented 4 years ago

@jperl ok, I like the playwright-video package. Let's see if with playwright we get the same functionality (eg: naming videos and multiple browser window support). I've tried _videoPath option but nothing is recorded.

jperl commented 4 years ago

@mortelee We will update playwright-video to playwright@1.4 and we can see if the video capture gets better with playwright@1.5 before deciding to deprecate playwright-video.

jperl commented 4 years ago

@mortelee The new release is based on playright@1.4.1, let me know if you run into any issues.