qax-os / goreporter

A Golang tool that does static analysis, unit testing, code review and generate code quality report.
Apache License 2.0
3.13k stars 273 forks source link

Can't exclude linters/spellcheck and vendor #19

Closed derekstavis closed 7 years ago

derekstavis commented 7 years ago

Looks like -e flag isn't working with linters/spellcheck.

When running goreporter on our project the following way:

$ goreporter -e vendor,linters/spellcheck -f json -p ../thunderbolt 

SpellCheck isn't being ignored. When running ignoring only vendor:

$ goreporter -e vendor -f json -p ../thunderbolt 

It looks like every linter is ignoring vendor, but SpellCheck isn't.

Evidences:

...
        "compress": {
          "name": "github.com/pagarme/thunderbolt/vendor/github.com/klauspost/compress",
          "description": "",
          "errors": [
            {
              "line_number": 23,
              "error_string": "/home/derek/go/src/github.com/pagarme/thunderbolt/vendor/github.com/klauspost/compress/README.md:23:141: \"progresssion\" is a misspelling of \"progressions\""
            },
            {
              "line_number": 200,
              "error_string": "/home/derek/go/src/github.com/pagarme/thunderbolt/vendor/github.com/klauspost/compress/README.md:200:121: \"descibed\" is a misspelling of \"described\""
            }
          ]
        },
...

wgliang commented 7 years ago

Yes, I understand your issue. SpellCheck is about to join linters, but I have not figured out how the page is displayed. This problem I will try to fix it as soon as possible. Thx!

wgliang commented 7 years ago

Now,you can pull last update and run goreporter on your project.Any questions can contact me. Thank you for issue.

wgliang commented 7 years ago

Did I solve your problem? I want to close the issue if you are ok. @derekstavis

derekstavis commented 7 years ago

Hey @wgliang, it solved my issue!! Thanks a lot for your time!!!