qax-os / goreporter

A Golang tool that does static analysis, unit testing, code review and generate code quality report.
Apache License 2.0
3.13k stars 273 forks source link

fixed the not finding packages bug and adjust the css for template html #59

Closed fearblackcat closed 6 years ago

fearblackcat commented 6 years ago

Fixed two issues. Issue 1: It will cause can't load package "PROJECT-NAME/MODULE/MODULE_NAME": cannot find package "PROJECT-NAME/MODULE/MODULE_NAME" in any of: /usr/local/go/src/PROJECT-NAME/MODULE/MODULE_NAME (from $GOROOT) /Users/Russell/golang/src/PROJECT-NAME/MODULE/MODULE_NAME (from $GOPATH) cannot find package "PROJECT-NAME/MODULE/MODULE_NAME" in any of: /usr/local/go/src/PROJECT-NAME/MODULE/MODULE_NAME (from $GOROOT) /Users/Russell/golang/src/PROJECT-NAME/MODULE/MODULE_NAME (from $GOPATH) errors when I pass the relate path under the GOPATH directory to the goreporter. e.g: $ cd $GOPATH/src/git.cloudware.com/ $ goreporter -p ./PROJECT-NAME -r ./ -f html The "git.cloudware.com" is vanity url. It's just a meaningless directory.

So I fixed this error in the utils.go

Issue 2: Before fixed the css: qq20180427-195140

After fixed the css: qq20180427-195204

Thanks!

codecov-io commented 6 years ago

Codecov Report

Merging #59 into master will increase coverage by 0.18%. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   31.67%   31.86%   +0.18%     
==========================================
  Files          18       18              
  Lines        1269     1274       +5     
==========================================
+ Hits          402      406       +4     
- Misses        828      829       +1     
  Partials       39       39
Impacted Files Coverage Δ
utils/utils.go 40.49% <80%> (+1.7%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e9b5682...3ca4f52. Read the comment docs.

wgliang commented 6 years ago

Thank you very much for your contribution.