search

qbarnes / cw2dmk

The new home of Tim Mann's CatWeasel support tools for TRS-80 floppy preservation. The Releases area contains binaries for MS-DOS and x86_64 Linux.
http://www.tim-mann.org/catweasel.html
GNU General Public License v2.0
16 stars 2 forks source link

Add -a rate_adj and -e dither options to dmk2cw. #7

Closed TimothyPMann closed 3 years ago

TimothyPMann commented 3 years ago

Plus: detect and error out if too high a -c value is used for the format.

TimothyPMann commented 3 years ago

Ugh, I usually don't make mistakes like "%1". I'll fix that as well as using the symbol instead of the word throughout.

From: Quentin Barnes @.> Sent: Thursday, November 18, 2021 8:11:56 AM To: qbarnes/cw2dmk @.> Cc: Tim Mann @.>; Author @.> Subject: Re: [qbarnes/cw2dmk] Add -a rate_adj and -e dither options to dmk2cw. (PR #7)

Merged #7https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fqbarnes%2Fcw2dmk%2Fpull%2F7&data=04%7C01%7Cmann%40vmware.com%7Cdc0e4a6edc0d4713bf5408d9aaae24a4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637728487185278633%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=v3tiJZ7OL2%2BXlLzFZ36kdQxCWoFLsktSbmQXxnSnrfw%3D&reserved=0 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fqbarnes%2Fcw2dmk%2Fpull%2F7%23event-5639889674&data=04%7C01%7Cmann%40vmware.com%7Cdc0e4a6edc0d4713bf5408d9aaae24a4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637728487185288595%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=JRVhNqK%2BdSdyKq6wpS4W8vQcJr%2BltV63vqqB4fggGb0%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAILDEHNYFHAQ4UDMKAZ2SE3UMUQUZANCNFSM5IDHP3AA&data=04%7C01%7Cmann%40vmware.com%7Cdc0e4a6edc0d4713bf5408d9aaae24a4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637728487185298557%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=chf8kWAHR6CKqrZ21KRx5wnO%2BjU4Nfg6S7UhkjFiGaU%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cmann%40vmware.com%7Cdc0e4a6edc0d4713bf5408d9aaae24a4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637728487185298557%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=IaQrCRBtl7lgW8HsZKBQ%2BeZ6UaKpDhOBEREwdIaAKf0%3D&reserved=0 or Androidhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cmann%40vmware.com%7Cdc0e4a6edc0d4713bf5408d9aaae24a4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637728487185308502%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=3w0Nf%2BH9tbRys%2Fsoi30MLfaonRUyz7Ldn%2BmcGX5z1m8%3D&reserved=0.

TimothyPMann commented 3 years ago

Fixing the dmk2cw.man typo in my rate_adj branch and doing a new pull request doesn't look like it is going to do the right thing in github. github previews this pull request as merging the whole branch again and tells me the branch can't be automatically merged. Is the preview just bogus or should I do this some other way?