qbcore-framework / qb-adminmenu

Admin Menu Using MenuV
GNU General Public License v3.0
43 stars 247 forks source link

Adding Weapon spawn list and Max mod car command and menu button #143

Closed RealStonerGamer closed 2 years ago

RealStonerGamer commented 2 years ago

making this to add Spawning Weapon list to Qb-adminmenu and to add maxmods to a car in menu and with command

i have just updated this to match with other PR's that just got added

RealStonerGamer commented 2 years ago

@GhzGarage i had to make a new PR i started my enhancement to the Menu with the new PR merge and wanted to clean some things up should be good now if you want to take a look again

RealStonerGamer commented 2 years ago

there all FIXED !!!

GhzGarage commented 2 years ago

@GhzGarage i had to make a new PR i started my enhancement to the Menu with the new PR merge and wanted to clean some things up should be good now if you want to take a look again

Sounds good thank you I will tonight!

RealStonerGamer commented 2 years ago

@GhzGarage i had to make a new PR i started my enhancement to the Menu with the new PR merge and wanted to clean some things up should be good now if you want to take a look again

Sounds good thank you I will tonight!

sounds good !

IdrisDose commented 2 years ago

Should be reverted, I too love callable events to modify vehicles and give weapons.

RealStonerGamer commented 2 years ago

Should be reverted, I too love callable events to modify vehicles and give weapons.

I mean you can disable all buttons your self this admin menu is more for help with dev things and also moderation of citys you do not need to use every feature this comes in handy for devs working on cars tuning them for there citys and also testing gun mods and custom gun edits

JericoFX commented 2 years ago

i think this need a layer of security first, at least check if the event is fired by qb-core (in the callback event) or from qb-admin and check if the source is actually an admin, just an idea