qbcore-framework / qb-bankrobbery

Bank Robbery For QB-Core
GNU General Public License v3.0
33 stars 185 forks source link

[BUG] Possible problem witth thermite door on Pacific Bank and lockpick. #83

Closed H1deMyFace closed 2 years ago

H1deMyFace commented 2 years ago

Describe the bug 1 When you use the thermite on the power station the door inside Pacific Bank bug thinking I'm using the power station.

Describe the bug 2 When you use the lockpick in Pacific Bank it is sometimes not removed from the inventory and the player uses as many times he wants.

To Reproduce Steps to reproduce the behavior:

  1. Go to power station then use the thermite.
  2. Indifferent if the power are off or on, go to Pacific Bank and make the puzzles.
  3. When you reach the thermite door the script send the notify: "The fuses are broken" and not open the door.

To Reproduce 2

  1. Try to use the lockpick and fail on the door.
  2. The lockpick sometimes got not removed from inventory and the player uses as many times he want.

Expected behavior Problem 1: Open the thermite door. Problem 2: Remove one lockpick everytime the player fail or win the puzzle.

Screenshots https://imgur.com/a/BHZa0kp

Questions (please complete the following information):

Additional context The only error is of the inventory but if I remember it's not related with the bank robbery. This problems happens so much times. The lockpick problem I don't know if it was really supposed to be like this or should always consume one. I don't have much time to look at the code and confirm this but I will help with whatever is needed and if it's not a bug I'm sorry for asking for help. For now, thanks.

xtxvxtx commented 2 years ago

Having an Issue with the first thermite door in Pacific Bank. image

BerkieBb commented 2 years ago

When you use the lockpick in Pacific Bank it is sometimes not removed from the inventory and the player uses as many times he wants.

This is not a bug, this is a feature of qb-doorlock, it only removes the lockpick by chance

BerkieBb commented 2 years ago

Having an Issue with the first thermite door in Pacific Bank. image

Update your qb-core

BerkieBb commented 2 years ago

When you reach the thermite door the script send the notify: "The fuses are broken" and not open the door.

Have you been to any of the power stations before doing this?

H1deMyFace commented 2 years ago

When you reach the thermite door the script send the notify: "The fuses are broken" and not open the door.

Have you been to any of the power stations before doing this?

Yes, I go to the ps and try a little. Afer I go to bank and try all the puzzles but when I reach the thermite the script get lost and believe I am in the ps.

H1deMyFace commented 2 years ago

When you use the lockpick in Pacific Bank it is sometimes not removed from the inventory and the player uses as many times he wants.

This is not a bug, this is a feature of qb-doorlock, it only removes the lockpick by chance

Ok thanks. I didn't learn many lines of code because I have a short time to this now. I was thinking the lockpick was removed every time, but now I see, it's more likely to be removed randomly when the player tries.

BerkieBb commented 2 years ago

When you reach the thermite door the script send the notify: "The fuses are broken" and not open the door.

Have you been to any of the power stations before doing this?

Yes, I go to the ps and try a little. Afer I go to bank and try all the puzzles but when I reach the thermite the script get lost and believe I am in the ps.

I tried to reproduce it by going to a powerstation and teleporting to the pacific bank but this didn't seem to bug, it opened the door fine and gave me the right notification

H1deMyFace commented 2 years ago

I wanna send a vid for u later. I didn't changed nothing on the lines of code. I have downloaded again the entire script but the same problem. Let me record the video.

H1deMyFace commented 2 years ago

Here:

https://streamable.com/563kmw

F8: image

BerkieBb commented 2 years ago

I am able to reproduce that, I'll fix it

H1deMyFace commented 2 years ago

Thank you