qbcore-framework / qb-clothing

Clothing Script Used With QB-Core :shirt:
GNU General Public License v3.0
33 stars 232 forks source link

Fix Armor Stays After refreshskin #153

Closed MrEvilGamer closed 1 year ago

MrEvilGamer commented 1 year ago

After refreshskin now the armor will stay as it was getting removed before.

Describe Pull request First, make sure you've read and are following the contribution guidelines and style guide and your code reflects that. Write up a clear and concise description of what your pull request adds or fixes and if it's an added feature explain why you think it should be included in the core.

If your PR is to fix an issue mention that issue here

Questions (please complete the following information):

tom-osborne commented 1 year ago

@MrEvilGamer @arsh939 When I tested this, using /refreshskin did indeed retain the armour value, but the vest clothing item was removed. Did you get the same result?

I think the intended design of this should be to keep the armour clothing when the player has armour enabled. So it would be good if we were to also replace the clothing item onto the player when refreshing the skin (as well as the armour value).

Is this something you could look into?

S33G commented 1 year ago

Closing due to age. Feel free to reopen should you revisit this.

Thanks