qbcore-framework / qb-core

FiveM RP Framework Core :muscle:
GNU General Public License v3.0
590 stars 960 forks source link

Backwards compatibility for vehicles.lua #1051

Closed xDope7137 closed 6 months ago

xDope7137 commented 11 months ago

Description

you can just drag and drop the vehicles from older vehicles.lua now

Checklist

MoskalykA commented 11 months ago

bad idea https://stackoverflow.com/questions/71276468/what-is-the-fastest-way-to-go-through-an-array-table-with-numeric-indices

xDope7137 commented 11 months ago

bad idea https://stackoverflow.com/questions/71276468/what-is-the-fastest-way-to-go-through-an-array-table-with-numeric-indices

buddy read the whole topic. they are enumerating 100,000+ values. People do not have more than 500 vehicles in that file.

by that logic, nothing should be using pairs. It does not sense to make it work for all small sized tables.

Besides, are you going to let all server owners to convert their whole car tables to new layout? To save 0.2ms compute time? Just one time every restart? smh

xDope7137 commented 11 months ago

image

MoskalykA commented 11 months ago

I'm just offering my opinion

github-actions[bot] commented 9 months ago

This PR has had 60 days of inactivity & will close within 7 days

xDope7137 commented 9 months ago

qb dead?

github-actions[bot] commented 7 months ago

This PR has had 60 days of inactivity & will close within 7 days

xDope7137 commented 7 months ago

qb dead dead