qbcore-framework / qb-core

FiveM RP Framework Core :muscle:
GNU General Public License v3.0
582 stars 962 forks source link

Fixed missing return statement in Player.Functions.HasItem #1091

Closed AdrianCeku closed 4 months ago

AdrianCeku commented 7 months ago

Description

self.Functions.HasItem calls QBCore.Functions.HasItem, but does not return any value due to a missing return statement.

I added the return statement so the function can be called from the Player Object instead of having to resort to calling QBCore.Function.HasItem and passing the source manually

Checklist

github-actions[bot] commented 4 months ago

This PR has had 60 days of inactivity & will close within 7 days

AdrianCeku commented 4 months ago

@Z3rio is this gonna be merged? This PR is literally one Word so I dont think it should take too much effort to merge

Z3rio commented 4 months ago

@Z3rio is this gonna be merged? This PR is literally one Word so I dont think it should take too much effort to merge

I believe you might be a bit confused. I do not have any affiliation with the qbcore organization, nor can I merge PRs. The only one who can merge PRs would be @GhzGarage

AdrianCeku commented 4 months ago

@Z3rio oh im sorry. I just assumed you were a dev form qb-core because but I should have probably checked beforehand 😅. My apologies

Z3rio commented 4 months ago

@Z3rio oh im sorry. I just assumed you were a dev form qb-core because but I should have probably checked beforehand 😅. My apologies

No worries, I used to do a lot of work for qbcore as I was the dev manager back then, so I understand why you might've thought that :)

Cocodrulo commented 4 months ago

I was the one that changed that file with a PR previously, my bad. This PR should be merged.