search

qbcore-framework / qb-core

FiveM RP Framework Core :muscle:
GNU General Public License v3.0
590 stars 960 forks source link

💱 Added money transfer functions #1099

Open Cocodrulo opened 7 months ago

Cocodrulo commented 7 months ago

Description

Implementation of the suggestion [SUGGESTION] Implement monetary transactions as a function. There have been added to two new functions. One in functions (QBCore.Functions.TransferMoney) and other one on player (Player.Functions.TansferTo), both aproach the same objective, trasnfering money betwwen two players if both are online, online one is online or both are offline.

Checklist

MonsieurBibo commented 7 months ago

Black money is not in the core, but crypto is, and you didn't put it in ?

Cocodrulo commented 7 months ago

Good point, but actually that information is only commented information, I mean is not really whitelisting those monetypes it is only info not actual code.

Anyway I'll fixed it tomorrow

Cocodrulo commented 7 months ago

Fixed the annotation and also renamed the Player.Functions.TransferTo to Player.Functions.TransferMoneyTo to make it self explainable.

Cocodrulo commented 3 months ago

Changed those things that you commented, you were right in all of them jajaja

Scartane commented 3 months ago

Changed those things that you commented, you were right in all of them jajaja

Will check that soon and let you know if I find something else

Cocodrulo commented 3 months ago

Sorry I added changes by mistake, changes reverted

Cocodrulo commented 3 months ago

Jus added logs and Money Events, a bit chunky the blocks of code but I don't know how to make it smaller.

github-actions[bot] commented 1 week ago

This PR has had 60 days of inactivity & will close within 7 days

Cocodrulo commented 6 days ago

Any update?

GhzGarage commented 2 days ago

Feel like this functionality could just be added onto AddMoney and RemoveMoney

Cocodrulo commented 2 days ago

I don't understand that