qbcore-framework / qb-core

FiveM RP Framework Core :muscle:
GNU General Public License v3.0
582 stars 962 forks source link

fix: gang/job validation #1111

Closed Z3rio closed 2 months ago

Z3rio commented 4 months ago

Description

It has come to my attention that there are ways for the job data to become unsynced. Such as the isboss value being saved as false, even though it's true in the shared files. (Via no kidding at least 20 tickets of said issue concerning my boss menu and qbcore's isboss state)

I'd imagine this can more specifically be recreated via already having a job, and then said jobs shared data being changed, whilst your "locally" saved player job data wouldn't update.

Therefore this PR aims to introduce validation of said data, to make sure it never ever gets out of sync.

Checklist