qbcore-framework / qb-drugs

Drugs Script For QB-Core :herb:
GNU General Public License v3.0
34 stars 184 forks source link

Fixed Dealer Bug Preventing Dealers from Appearing #124

Closed gamenew09 closed 1 year ago

gamenew09 commented 1 year ago

Describe Pull request Fixes #120 #114 #113

This pull request modifies the check that attempts to make sure that the if the Config.Dealers table is empty, we don't continue to initialize the PolyZones/targeting for the loaded dealers. While it seems like just removing that line fixes the issue, I did see that if there is no check it'll still create a ComboZone and it'll try and look for players entering/exiting that zone. My code will not create a zone unless a dealer is made, saving some perf (albeit probably very minimal).

I am aware of PR #123 but I wanted to submit a separate pull request so this fix could be pushed in relatively quick.

Questions (please complete the following information):

ae453 commented 1 year ago

Definitely a better fix. Nice work!

gamenew09 commented 1 year ago

Definitely a better fix. Nice work!

Thanks!

MentalIllness commented 1 year ago

Thanks for the pull request. Will be merged soon.