search

qbcore-framework / qb-garages

Garage System Used With QB-Core :car:
GNU General Public License v3.0
48 stars 260 forks source link

[BUG] Depot Bug #229

Closed mrsanten closed 1 year ago

mrsanten commented 2 years ago

Describe the bug There is some kind of problem with depot. When I take out a vehicle out of depot and later come back to it, there is no marker on the ground but there is an information box on the right (press E to...). After that all the garages disappear. In the F8 console I get the error: image

To Reproduce Steps to reproduce the behavior:

  1. Go to depot and take out a car
  2. Ride somewhere and get back to the depot
  3. Try to open a depot.

(Not sure if it'll work if you'd have more cars in depot.

Questions (please complete the following information):

Feel free to contact me here or on discord: Santen#6806

GhzGarage commented 2 years ago

Alright i'll check it tonight

mrsanten commented 2 years ago

Great, let me know if you have any problems recreating it.

mrsanten commented 2 years ago

When I first reported it I was using my custom config file so I reseted and used the clear qb-garages-3aa1a085ae761d1d66be6b361874af1215d421db

Same happens here. I took a vehicle out of depot. Took it to other garage and put it in. When I /tpm back to the depot the marker was gone and there is an error in console: image

mrsanten commented 2 years ago

@GhzGarage Any luck recreating it?

amantu-qbit commented 2 years ago

@mrsanten Is should be a Config issue. But LET ME KNOW if it's fixed

blinkyAU commented 1 year ago

I may have found the fix,

qb-garages\config.lua (line 170)

["impoundlot"] = { label = "Impound Lot", takeVehicle = vector3(409.89, -1623.51, 29.29), spawnPoint = vector4(407.92, -1646.29, 29.29, 226.39), putVehicle = vector3(408.92, -1656.29, 30.29), <<< this line was missing from the config. (the coords are made up, I have no idea what they are supposed to be.) showBlip = true, blipName = "Impound Lot", blipNumber = 68, type = 'depot', --public, job, gang, depot vehicle = 'car' --car, air, sea

i have people on my test server thoroughly testing after above code applied and no issue so far except for below.

but now there is a new issue i have to work out image

I am not a developer for QB-core or a contributor, please don't ask me for help i suck at coding. i found this by chance.

github-actions[bot] commented 1 year ago

This issue has had 60 days of inactivity & will close within 7 days