qbcore-framework / qb-garages

Garage System Used With QB-Core :car:
GNU General Public License v3.0
48 stars 260 forks source link

[BUG] Bugs when using recent 'SharedPublicGarages' config option. #294

Closed ExpiredMilk244 closed 1 year ago

ExpiredMilk244 commented 1 year ago

Describe the bug The first bug is when a vehicle is /dv, it doesn't respawn in any of the garages. It is still in the database, but doesn't show in any of the garages. The only way it will reappear is when you restart the server The second bug is that you can pull sea vehicles and air vehicles out of car garages. Please note, both of these bugs are when using the latest config option, 'SharedPublicGarages'.

To Reproduce Steps to reproduce the behavior: (Bug 1)

  1. Give yourself a vehicle.
  2. Pull out of garage.
  3. /dv the vehicle.
  4. Go back to garage and see the vehicle is now gone.
  5. See that the vehicle still exsists in the player_vehicles table in the database.
  6. Restart server to fix. (Bug 2)
  7. Give yourself a sea or air vehicle.
  8. Put in sea or air garage.
  9. Pull sea/air vehicle out of car garage.

Expected behavior (Bug 1) When a car is /dv, it should either go to impound or back to garage based off config 'AutoRespawn' option, which is true in my case. Restarting the server fixes this issue.

Screenshots I don't think screenshots may be relevant to these bugs, but I can always add them if needed.

Questions (please complete the following information):

Additional context Not sure if the second bug is intentional, however it is an issue when you can pull boats and planes out in a car park.

github-actions[bot] commented 1 year ago

This issue has had 60 days of inactivity & will close within 7 days