Fix linting issues - Githubissues

qbcore-framework / qb-hud

Player HUD System

45 stars 209 forks source link

Fix linting issues #161

Closed D4isDAVID closed 2 years ago

D4isDAVID commented 2 years ago

Describe Pull request Fix linter issues introduced by 31fabf5 and #145

Questions (please complete the following information):

Have you personally loaded this code into an updated qbcore project and checked all it's functionality? no
Does your code fit the style guidelines? yes
Does your PR fit the contribution guidelines? yes

tom-osborne commented 2 years ago

@D4isDAVID not sure why the linter is confused, but engine is used in a few places. Have you checked this doesn't cause any issues?

D4isDAVID commented 2 years ago

@D4isDAVID not sure why the linter is confused, but engine is used in a few places. Have you checked this doesn't cause any issues?

Actually it doesn't seem to be used. In line 547 it gets assigned a value, and although the word engine comes up in a few places like other variables and a table, in the table it shows up as a key and not a value (line 653). The variable itself doesn't seem to be used anywhere.

D4isDAVID commented 2 years ago

Actually I should remove that variable assignment as well...