qbcore-framework / qb-inventory

Slot Based Inventory System Used With QB-Core :school_satchel:
GNU General Public License v3.0
51 stars 380 forks source link

[BUG][security] DUPLICATE ANY ITEM IN YOUR INV #283

Closed PT-Mohamed-Hussein closed 10 months ago

PT-Mohamed-Hussein commented 2 years ago

Describe the bug just duplicate any item through any job i will show u video on how to reproduce it and u can try it with any job

To Reproduce Steps to reproduce the behavior: https://youtu.be/4LlWMjzQuBk

Expected behavior it is expected to give me x number of stones not of uranium

Screenshots https://youtu.be/4LlWMjzQuBk

Questions (please complete the following information):

LYRYCAL commented 2 years ago

Describe the bug just duplicate any item through any job i will show u video on how to reproduce it and u can try it with any job

To Reproduce Steps to reproduce the behavior: https://youtu.be/4LlWMjzQuBk

Expected behavior it is expected to give me x number of stones not of uranium

Screenshots https://youtu.be/4LlWMjzQuBk

Questions (please complete the following information):

* When you last updated: [e.g. last week]

* Are you using custom resource? which ones? [e.g. zdiscord, qb-target]
  qb-target
  qb-mining

* Have you renamed `qb-` to something custom? [e.g. yes/no]
  yes to `ww-` to avoid the register key mapping issue
  **Additional context**
  i think its some thing with slots bec the glitch is only happens when u have 0 item from the expected item u will recieve for example
  if i have 0 stone the problem showed above will happen while if i have 1 stone it wont happen

my man.. the inventory on your video is from Inventory, so you need to ask the author how to fix that.

PT-Mohamed-Hussein commented 2 years ago

Describe the bug just duplicate any item through any job i will show u video on how to reproduce it and u can try it with any job To Reproduce Steps to reproduce the behavior: https://youtu.be/4LlWMjzQuBk Expected behavior it is expected to give me x number of stones not of uranium Screenshots https://youtu.be/4LlWMjzQuBk Questions (please complete the following information):

* When you last updated: [e.g. last week]

* Are you using custom resource? which ones? [e.g. zdiscord, qb-target]
  qb-target
  qb-mining

* Have you renamed `qb-` to something custom? [e.g. yes/no]
  yes to `ww-` to avoid the register key mapping issue
  **Additional context**
  i think its some thing with slots bec the glitch is only happens when u have 0 item from the expected item u will recieve for example
  if i have 0 stone the problem showed above will happen while if i have 1 stone it wont happen

my man.. the inventory on your video is from Inventory, so you need to ask the author how to fix that.

Actually same issue goes to qb one but i couldmt make the vid for it alone

LYRYCAL commented 2 years ago

Actually same issue goes to qb one but i couldmt make the vid for it alone

Have you try this one? #263

PT-Mohamed-Hussein commented 2 years ago

guys have u see the video ? before trying give me fixes ?

TransitNode commented 2 years ago

You can only replicate this bug with jobs that drop items on the ground? Not all jobs drop items on the ground. qb-mining doesn't seem to be officially apart of this framework could you link us the source of the qb-mining you are using?

PT-Mohamed-Hussein commented 2 years ago

no it isn't about dropping the item its about any thing using Player.Function.GiveItem() while u are opening the inventory when u got any item while another item is being given to u like in the video this will always happens

github-actions[bot] commented 1 year ago

This issue has had 60 days of inactivity & will close within 7 days

github-actions[bot] commented 10 months ago

This issue has had 60 days of inactivity & will close within 7 days