qbcore-framework / qb-inventory

Slot Based Inventory System Used With QB-Core :school_satchel:
GNU General Public License v3.0
50 stars 380 forks source link

[ENHANCEMENT] Deprecate HasItem callback #370

Closed i-kulgu closed 1 year ago

i-kulgu commented 1 year ago

Description

Deprecate HasItem callback since it's not used anymore in any QB script.

Checklist

i-kulgu commented 1 year ago

If deprecated, shouldn't it be fully removed anyways? We have logs / backups of every change through this github repository. So no need to comment out the code, it just makes it less readable and such.

I will gladly approve this if you remove the callback instead of commenting it :)

I had let it stay so people who STILL have the HasItem callback could easily uncomment it to use but i have removed as you asked.

Z3rio commented 1 year ago

If deprecated, shouldn't it be fully removed anyways? We have logs / backups of every change through this github repository. So no need to comment out the code, it just makes it less readable and such. I will gladly approve this if you remove the callback instead of commenting it :)

I had let it stay so people who STILL have the HasItem callback could easily uncomment it to use but i have removed as you asked.

Yeah, I understand. I will take a look at this PR soon 👍🏼 Although by the looks of it, qb-houserobbery & qb-tunerchip still use these callbacks, and therefore I would need to change those to the actual export before committing this PR.