search

qbcore-framework / qb-inventory

Slot Based Inventory System Used With QB-Core :school_satchel:
GNU General Public License v3.0
50 stars 377 forks source link

Prevent Exploit #389

Closed MrEvilGamer closed 1 year ago

MrEvilGamer commented 1 year ago

prevent exploit

Z3rio commented 1 year ago

Hello, I would love to approve this since we obviously dont want exploits in qb-core.

But which exploit are you talking about? It would be great if you included such information in your PR's since this is vital for us to be able to test your addons to the framework.

Because it seems alot like this isnt fixing the actual exploit, more or less just a temporary way around it.

MrEvilGamer commented 1 year ago

https://cdn.discordapp.com/attachments/868677507057090581/927607832960987166/FiveM_-_THE_LEGENDS_ROLEPLAY_2022-01-03_22-31-00.mp4

MrEvilGamer commented 1 year ago

here

Z3rio commented 1 year ago

here

Hm yeah, this wouldnt really be a good fix for that issue. What should be changed is to make moving items / dropping items not allowed when doing actions such as this one.

I will take a look at how this could be done. Thank you for showing the issue sir.

MrEvilGamer commented 1 year ago

all good mate :)

Z3rio commented 1 year ago

Closed, not valid fix. Reopen if you still want to fix it.