search

qbcore-framework / qb-inventory

Slot Based Inventory System Used With QB-Core :school_satchel:
GNU General Public License v3.0
50 stars 377 forks source link

[ENHANCEMENT] Added progress bar to opening inventory event #394

Closed AnishBplayz closed 9 months ago

AnishBplayz commented 1 year ago

Description

This is an enhancement PR.

The PR Title Describes about it.

AnishBplayz commented 1 year ago

Lint issue - As there are spaces after TAB it shows merge block, will fix it soon if necessary other wise it should be good to merge

AnishBplayz commented 1 year ago

I dont believe people would actually like this to be honest. Considering most people want the inventory to open as fast as possible.

If you really want this to get added, then it should have a config value to turn it on / off.

Noted... will add a config value to it.

AnishBplayz commented 1 year ago

@Z3rio I have added the Config Value to it, also the lint issue is still about inconsistent indentation spaces followed by TAB it should be good to merge now....

AnishBplayz commented 1 year ago

lint fixed :) @Z3rio

AnishBplayz commented 1 year ago

Done @Z3rio

AnishBplayz commented 1 year ago

@Z3rio The branch is synced and should be good to merge now

SKITTLE6969 commented 1 year ago

This works and has stopped all the item drop bugs!!! Thanks for this man <3

AnishBplayz commented 1 year ago

Good to hear that @SKITTLE6969 Buddy <3

AnishBplayz commented 1 year ago

@Z3rio It should be good to merge, Requesting for Review again!

github-actions[bot] commented 11 months ago

This PR has had 60 days of inactivity & will close within 7 days