search

qbcore-framework / qb-mechanicjob

Mechanic Job For QB-Core
GNU General Public License v3.0
33 stars 174 forks source link

Update for qb-target and polyzone #28

Closed deandum closed 2 years ago

deandum commented 2 years ago

To enable qb-target go to config.lua and change UseTarget.

This PR should not be merged until qb-core:DrawText is merged on master.

uShifty commented 2 years ago

Not to be that guy but this PR seems kinda half done their is still so much more you need to do for proper polyzone integration. You can remove the setclosestplate thread entirely and replace it with polyzone and you can remove some of the other threads with self killing threads so they are not running 24/7 when it is not in use

deandum commented 2 years ago

Not to be that guy but this PR seems kinda half done their is still so much more you need to do for proper polyzone integration. You can remove the setclosestplate thread entirely and replace it with polyzone and you can remove some of the other threads with self killing threads so they are not running 24/7 when it is not in use

Yeah well, it would be nice to have an "official" document that explains what is expected from this update. With all the resources I've worked with, I tried to keep the existing functionality when UseTarget is false or not set. So this is why I left all the other code in there. Also, if a thread does not have a loop in it, it does not run 24/7 according to the FiveM docs.