qbcore-framework / qb-multicharacter

Multi-Character System Used With QB-Core :man: :woman:
GNU General Public License v3.0
32 stars 237 forks source link

[ENHANCEMENT] Scroll bar fix! #190

Closed r0adra93 closed 1 year ago

r0adra93 commented 1 year ago

the buttons are at the bottom of the list this means when you have a lot of character slots you have to scroll to the bottom to get to the button.

I made it so you don't have to scroll to see the buttons by moving the overflow and scroll buttons from the characters-list div to the characters div and I resized the characters element to allow the buttons to be viewable.

Describe Pull request First, make sure you've read and are following the contribution guidelines and style guide and your code reflects that. Write up a clear and concise description of what your pull request adds or fixes and if it's an added feature explain why you think it should be included in the core.

If your PR is to fix an issue mention that issue here

Questions (please complete the following information):

Z3rio commented 1 year ago

I'm sorry for the mis understanding, I meant that fit-contents not fit-content doesnt exist. I will fix that for you since its my fault.

Z3rio commented 1 year ago

Only issue I saw was that the scrollbar is right next to the characters which looks quite ugly. I will go ahead and fix that aswell by simply adding some padding to .characters

Before: image

After: image