qbcore-framework / qb-policejob

Police Job & Evidence System For QB-Core :police_officer: :policewoman:
GNU General Public License v3.0
71 stars 378 forks source link

[BUG] Remove Object doesn't exists #477

Closed Amrizamaa closed 10 months ago

Amrizamaa commented 1 year ago

Describe the bug When trying via the radial menu to remove an object that does not exist (nothing in front of you or around) there is a console error message on the client side.

To Reproduce Steps to reproduce the behavior:

  1. Open Radial Menu
  2. Work / objects / delete objects (when nothing front of the player)
  3. Error on the console Attempt to compare a nil with number @qb-policejob/client/objects.lua:180
  4. See error

Expected behavior A notification to say maybe there are nothing to delete

Screenshots image image

Questions (please complete the following information):

Additional context Creating a pull request soon with the fix

Amrizamaa commented 1 year ago

Fix Verification : https://github.com/qbcore-framework/qb-policejob/pull/478/commits/34f0350a7a61c675418976ea3c8c811efecfffc5 & Add Translations for notification : https://github.com/qbcore-framework/qb-policejob/pull/478/commits/b56ecb89bf7797ab7ddb3b1e8a01f40f13bf7840

github-actions[bot] commented 1 year ago

This issue has had 60 days of inactivity & will close within 7 days

Amrizamaa commented 1 year ago

it's so bad being ignored

github-actions[bot] commented 10 months ago

This issue has had 60 days of inactivity & will close within 7 days