qbcore-framework / qb-smallresources

A compilation of small resources combined into one
GNU General Public License v3.0
52 stars 349 forks source link

[ENHANCEMENT] Refactoring & Optimization #294

Closed KamuiKody closed 1 year ago

KamuiKody commented 1 year ago

Describe Pull request

To keep organized i am going to make a list of how i went through this: afk - works set a timer to test it while i moved onto other tests moved afk stuff to the config not sure why admin ignoring has never worked binoculars - use the item works fine spam using the item to make sure it breaks the loop and doesnt overlap them calmai - dont think i changed this but npcs dont try to fight me so theres that carwash - added pz and target need to test both pz and target consumables - i have made it so it auto adds a useable item and the progress stuff based on table location of the item also added an option to create custom consumables and even add an event to the end of the progressbar right in the config. crouchprone - same as binoculars and the prone never worked correctly for me fully cruise - works when i press the button and breaks when cruise isnt on discord - didnt want to congest config too much so i left this alone figure if ur setting discord rich presence u probably are familiar with editting a client file editor - did not change fireworks - use several no repeated loops and they work handsup - did not change hud components - already merged ignore - added config for stuntime and broke infinite ammo loop when weapons not out needs my pr from inventory to work no shuff - moved to a command spammed to see if the loop spams and it doesn and shuffle and no shuffle work fine point - didnt change anything recoil - also used weapons event from inventory remove entity - breaks loops completely and utilizes polyzones instead this was buy far a huge improvement seatbelt - loops broke put on command command works loops dont overlap tackle - same as seatbelt teleports - utilized qb-menu so more zones can be added to a sinlge teleport, again killed the loops vehiclepush - utilized targeting bones and put push on a toggle vehicle text - did not change weapon draw - killed loop and utilized my pr for inventory weapondrop - didnt change logs- didnt change

It removed my old PR when i merged the changes here are the things that have been looked at by stan so far. "I have reviewed the following files in this PR:

client/afk.lua - Good to go client/binoculars.lua client/carwash.lua - Needs to be reverted, does not work. client/consumables.lua client/handsup.lua client/hudcomponents.lua client/point.lua client/vehicletext.lua server/main.lua Anything in the PR not listed above requires code review and testing."

If your PR is to fix an issue mention that issue here

Questions (please complete the following information):

Z3rio commented 1 year ago

I will test this when I get home, I believe the merge conflicts for client/cruise.lua should be resolved.