Refactor AFK function + Support for Logged out + Fix Locale message

qbcore-framework / qb-smallresources

A compilation of small resources combined into one

GNU General Public License v3.0

50 stars 348 forks source link

Refactor AFK function + Support for Logged out + Fix Locale message #333

Closed S33G closed 1 year ago

S33G commented 1 year ago

Much less spagetti code
Reinstates locale message as it was missing
Includes AFK for logged out users (ie. qb-multicharacter)
Adds config option for enable/disable
Changed notification duration to avoid overlapping notifications

Fixes: https://github.com/qbcore-framework/qb-smallresources/issues/281

Duplicates: https://github.com/qbcore-framework/qb-smallresources/pull/331

DuoTheDev commented 1 year ago

Hello. I went ahead and tested this to make sure it behaved how I intended. It seems to be good to me.

I still like the idea of adding a different configurable afk timer for the time before the player logs in. I just think that it should be shorter than a player who is logged in. Would be open to discussing this more and hearing your thoughts!

S33G commented 1 year ago

Hello. I went ahead and tested this to make sure it behaved how I intended. It seems to be good to me.

I still like the idea of adding a different configurable afk timer for the time before the player logs in. I just think that it should be shorter than a player who is logged in. Would be open to discussing this more and hearing your thoughts!

I feel this pr does enough right now and is still an improvement on what we have currently. Maybe we can introduce another config variable once this one is merged :)