qbcore-framework / qb-smallresources

A compilation of small resources combined into one
GNU General Public License v3.0
50 stars 348 forks source link

Add alot more vehicles & peds to blacklist #346

Closed SPKReality closed 1 year ago

SPKReality commented 1 year ago

Describe Pull request First, make sure you've read and are following the contribution guidelines and style guide and your code reflects that. Write up a clear and concise description of what your pull request adds or fixes and if it's an added feature explain why you think it should be included in the core.

If your PR is to fix an issue mention that issue here

Questions (please complete the following information):

1.) Yes 2.) Yes 3.) Yes

tom-osborne commented 1 year ago

This would break since you have changed the keys from hashes (strings converted to a hash using ` back ticks) to strings.

This table is used here:https://github.com/qbcore-framework/qb-smallresources/blob/main/server/entities.lua#L4

The key used is the value returned by GetEntityModel(), which returns the hash, so you need to use backticks to convert the string to a hash.

SPKReality commented 1 year ago

Should be fine now mate

McKlean commented 1 year ago

Why are you blacklisting perfectly good vehicles? Motorbikes, Issi, there are some perfectly good vehicles in their that doesn't need to be blacklisted at all

SPKReality commented 1 year ago

Just went through alot of vehicle models and added them so I may have added wrong ones too

tom-osborne commented 1 year ago

Agree, I don't see the point in this PR if you have added these for no reason.