search

qbcore-framework / qb-smallresources

A compilation of small resources combined into one
GNU General Public License v3.0
50 stars 348 forks source link

Made tagEveryone into a string and changed it to tag #348

Closed r0adra93 closed 1 year ago

r0adra93 commented 1 year ago

Converted tagEveryone boolean into a string. If the variable is set to false or nil it will still process through. It will leave a console message if the tag is a boolean instead of a string containing the name of the group like admin or the dreaded everyone.

Describe Pull request First, make sure you've read and are following the contribution guidelines and style guide and your code reflects that. Write up a clear and concise description of what your pull request adds or fixes and if it's an added feature explain why you think it should be included in the core.

If your PR is to fix an issue mention that issue here

Questions (please complete the following information):

tom-osborne commented 1 year ago

@r0adra93 So what do we do if people do want to tag everyone?

It's already configurable as @Jorn08 pointed out, so if you don't want it then disable it. I don't see the point in this PR, please close.

r0adra93 commented 1 year ago

@r0adra93 So what do we do if people do want to tag everyone?

It's already configurable as @Jorn08 pointed out, so if you don't want it then disable it. I don't see the point in this PR, please close.

it's a bullshit tag I can look into modifying it to allow @everyone to be set to w/e they want it to be and just filter out "true"

caused havoc in a log that was chosen to be public and it woke up every fucking member that had discord on their phone! it was a builtin message in the core and I had to deal with the freaking headache.

tom-osborne commented 1 year ago

Adding an extra config option to be able to select which tag ID would be a neater solution.

The code tagging everyone in your discord is on you though. If it is setup right, you wouldn't get that issue. Doing a global fix to remove a feature off the back of that is not correct.

r0adra93 commented 1 year ago

Adding an extra config option to be able to select which tag ID would be a neater solution.

The code tagging everyone in your discord is on you though. If it is setup right, you wouldn't get that issue. Doing a global fix to remove a feature off the back of that is not correct.

I solved the issue with the core tagging EVERYONE. I wanted to prevent this out of a raging temper as some dodo tagged "everyone" in a log within the core itself. It was pushed through which was even worse! So I threw the baby out with the bathwater. I fixed it though.