qbcore-framework / qb-target

A better interaction system for FiveM
GNU General Public License v3.0
94 stars 240 forks source link

[BUG] Font Awesome Eye Not Showing #195

Closed snalye closed 9 months ago

snalye commented 9 months ago

Describe the bug For some of my players, the font awesome eye, far fa-eye, is not showing for them. When they reach an interactable area, the options show but the eye itself does not show. However, for some players the eye does show up. Unsure if this is a font awesome issue, a client issue, or an issue with the latest FiveM build.

To Reproduce Steps to reproduce the behavior:

  1. Hold target keybind
  2. Locate a target zone

Expected behavior When holding the keybind, you should expect to see the font awesome eye.

Screenshots Player Video of it not working Player Video of it not working Player screenshot of it working New error since Feb 7th

Additional context On the current version of qb-target.

qbplayer commented 9 months ago

Describe the bug

I'll add to this, around 50% of our serverbase cannot view the third eye, as many have discussed on discord there have been no server changes and we haven't added or removed any files. It was working fine until today when we immediately started receiving reports from players. I can see there have been no changes to qb-target which makes it strange but with the amount of reports at least its now a common issue.

The third eye doesn't show but if you right click the target, it does still show its options. So at least the keybind is actually working

To Reproduce Steps to reproduce the behavior:

Hold target keybind ALT Locate a target zone eg. qb-atm

Expected behavior When holding the keybind, you should expect to see the blue eye.

Additional context

I have personally reinstalled GTA Reinstalled FiveM Updated all windows drivers Update graphics drivers

tested on PC Windows 10 tested on Laptop Windows 11

I confirmed far fa-eye icon is working from fontawesome and replaced with other icons that i know do work to no avail StandardEyeIcon: "far fa-eye",

I reinstalled a fresh qbcore on a test server

I visited other cities on fivem advertised as qbcore

The third eye just does not show

0takusensei commented 9 months ago

218_20240209043216_1 same my eye isnt working either but the options are in there

therealnoskill commented 9 months ago

same issue here

ihustle662 commented 9 months ago

same issue just started all of a sudden

ghost commented 9 months ago

Assuming it is something within the font awesome import functionality. Any icon, free or not, does not work within qb-target. Fresh installed qb-target to no avail

SwagDaddyBrad commented 9 months ago

Having this issue as well!

KK7130 commented 9 months ago

Having the same issue. Was working yesterday perfectly fine. Today me and multiple people on my server are having this issue and getting this error code; SCRIPT ERROR: Error executing native 0xfcdff7b72d23a1ac at address FiveM_b2944_GTAProcess.exe+1611463. ; RaycastCamera^7 (^5@qb-target/client.lua^7:113). Not sure what it means or what would have caused it?

ryuque commented 9 months ago

The same thing happened on our server. However, there are two types issue: those for whom it happens and those for whom it does not.

Here is the solution. However, this solution is a guess based on experimentation.

In the Setting/Game/Update channel of the front page of Fivem on the front page of Fivem is "Release" and Ver. 7424 and the channel is Ver. 7424.

On our server, when this problem occurred, we assumed that the cause of this problem was a failed download of Font Awesome. Therefore, we localized Font Awesome, but this did not solve the problem.

We therefore concluded that the problem was caused by a different version of Fivem.

ryuque commented 9 months ago

If this does not cure the issue, it can only be due to the individual's environment.

Probably from KK7130's report, error due to a https://docs.fivem.net/natives/?_0xFCDFF7B72D23A1AC HasEntityClearLosToEntity

Translation from Japanese

GhzGarage commented 9 months ago

Can you try this and see if it resolves the issue? https://github.com/qbcore-framework/qb-target/pull/196

snalye commented 9 months ago

Can you try this and see if it resolves the issue? #196

Will give it a try. Locally works fine but will update after being pushed to my players.

ghost commented 9 months ago

Can you try this and see if it resolves the issue? #196

negative on this

TKDubsta commented 9 months ago

Can you try this and see if it resolves the issue? #196

negative on this

Hey, can you try replacing your fontawesome import on line 5 of index.html with this:

<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/font-awesome@4.7.0/css/font-awesome.min.css">
Wert22 commented 9 months ago

Hi, I was quite surprised when I encountered this problem, but I found something like this for a solution. You can try if you want.

Steps :

My photo :

image

Note: This works for me, you can give feedback by trying it, thank you.

TKDubsta commented 9 months ago

Hi, I was quite surprised when I encountered this problem, but I found something like this for a solution. You can try if you want.

Steps :

  • Open qb-target/html/js/app.js
  • In data paramaters find TargetEyeStyleObject and display like mine below: Assign a "block" value

My photo :

image

Note: This works for me, you can give feedback by trying it, thank you.

this is not the ideal fix as you are adding more load by not using v-show. Try implementing the change #196

kathryn2101 commented 9 months ago

Can you try this and see if it resolves the issue? #196

i did this and now get this error

image

snalye commented 9 months ago

Can you try this and see if it resolves the issue? #196

i did this and now get this error

image

I've got that error before and after the potential fix

kathryn2101 commented 9 months ago

Can you try this and see if it resolves the issue? #196

i did this and now get this error image

I've got that error before and after the potential fix

Sorry ive only just noticed this issue not been very well past few days so just catching up now to the latest issue

rivickys commented 9 months ago

How to fix qb-target issue goto qb-target/html/index.html

change the font awesome link to this one in line 15 https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.4.2/css/all.min.css

Wert22 commented 9 months ago

Hi, I was quite surprised when I encountered this problem, but I found something like this for a solution. You can try if you want. Steps :

  • Open qb-target/html/js/app.js
  • In data paramaters find TargetEyeStyleObject and display like mine below: Assign a "block" value

My photo : image Note: This works for me, you can give feedback by trying it, thank you.

this is not the ideal fix as you are adding more load by not using v-show. Try implementing the change #196

As I said, this is already a temporary method. It can be used in a temporary way until we solve it with a smoother method.

snalye commented 9 months ago

How to fix qb-target issue goto qb-target/html/index.html

change the font awesome link to this one in line 15 https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.4.2/css/all.min.css

Line 15 is the Line Awesome link https://github.com/qbcore-framework/qb-target/blob/76bffd7937630933ffc15e070f0e8b5d2a28ba69/html/index.html#L15

Line 5 is the font awesome https://github.com/qbcore-framework/qb-target/blob/76bffd7937630933ffc15e070f0e8b5d2a28ba69/html/index.html#L5

snalye commented 9 months ago

Going to attempt to change the eye from far fa-eye to las la-eye and see what players say

https://github.com/qbcore-framework/qb-target/blob/76bffd7937630933ffc15e070f0e8b5d2a28ba69/html/js/app.js#L6

snalye commented 9 months ago

Can you try this and see if it resolves the issue? #196

No change from this or from my icon change. Some of my players still do not see the eye.

Now getting a report that a player who previously did not have it, got it back after one of our server restarts but I did not push any changes until an hour ago.

ryuque commented 9 months ago

In the server at our place, I have found people who have solved the problem by the following methods.

ーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーー Match the game version to Release  Ver. 7424

Delete (uninstall) all games from the folder

Download Fivem again. ーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーー

On our server I have made changes so that I can use the fonts locally without having to download the https://cdn.jsdelivr.net/npm/@fortawesome/fontawesome-free/css/all.min.css

However, this did not solve the problem, so it does not appear to be the cause of the failure to download the Font.

The cause is probably due to a version change related to ”Show”.

ghost commented 9 months ago

In the server at our place, I have found people who have solved the problem by the following methods.

ーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーー Match the game version to Release  Ver. 7424

Delete (uninstall) all games from the folder

Download Fivem again. ーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーー

On our server https://cdn.jsdelivr.net/npm/@fortawesome/fontawesome-free/css/all.min.css I have made changes so that I can use the fonts locally without having to download the https://cdn.jsdelivr.net/npm/@fortawesome/fontawesome-free/css/all.min.css

However, this did not solve the problem, so it does not appear to be the cause of the failure to download the Font.

Change your body in index.html to this

<body>
    <div id="target-wrapper">
        <q-icon id="target-eye" :name="CurrentIcon" v-if="Show" :style="TargetEyeStyleObject"></q-icon>
        <div id="target-label-wrapper">
            <div id="target-label"></div>
        </div>
    </div>
</body>

It's a temp fix we devised in the discord today that alleviated my issues

TKDubsta commented 9 months ago

How to fix qb-target issue goto qb-target/html/index.html

change the font awesome link to this one in line 15 https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.4.2/css/all.min.css

this is not correct.

TKDubsta commented 9 months ago

In the server at our place, I have found people who have solved the problem by the following methods. ーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーー Match the game version to Release  Ver. 7424 Delete (uninstall) all games from the folder Download Fivem again. ーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーー On our server https://cdn.jsdelivr.net/npm/@fortawesome/fontawesome-free/css/all.min.css I have made changes so that I can use the fonts locally without having to download the https://cdn.jsdelivr.net/npm/@fortawesome/fontawesome-free/css/all.min.css However, this did not solve the problem, so it does not appear to be the cause of the failure to download the Font.

Change your body in index.html to this

<body>
    <div id="target-wrapper">
        <q-icon id="target-eye" :name="CurrentIcon" v-if="Show" :style="TargetEyeStyleObject"></q-icon>
        <div id="target-label-wrapper">
            <div id="target-label"></div>
        </div>
    </div>
</body>

It's a temp fix we devised in the discord today that alleviated my issues

to confirm, this is pull request #196

We are working on a different long term solition however this fixes it for now.

snalye commented 9 months ago

In the server at our place, I have found people who have solved the problem by the following methods. ーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーー Match the game version to Release  Ver. 7424 Delete (uninstall) all games from the folder Download Fivem again. ーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーー On our server https://cdn.jsdelivr.net/npm/@fortawesome/fontawesome-free/css/all.min.css I have made changes so that I can use the fonts locally without having to download the https://cdn.jsdelivr.net/npm/@fortawesome/fontawesome-free/css/all.min.css However, this did not solve the problem, so it does not appear to be the cause of the failure to download the Font.

Change your body in index.html to this

<body>
    <div id="target-wrapper">
        <q-icon id="target-eye" :name="CurrentIcon" v-if="Show" :style="TargetEyeStyleObject"></q-icon>
        <div id="target-label-wrapper">
            <div id="target-label"></div>
        </div>
    </div>
</body>

It's a temp fix we devised in the discord today that alleviated my issues

Will attempt this but won't have any results until tomorrow.

snalye commented 9 months ago

Fixed with https://github.com/qbcore-framework/qb-target/issues/195