qbcore-framework / qb-taxijob

Taxi Job For QB-Core
GNU General Public License v3.0
26 stars 159 forks source link

[BUG] Infinite money by abusing the taxi toll. #59

Closed spicebag closed 1 year ago

spicebag commented 1 year ago

Describe the bug When using the taxi job, you can make infinite money by taking a passenger and driving around a lot before delivering the passenger.

To Reproduce Steps to reproduce the behaviour:

  1. Start Job
  2. Take Passenger and start the journey
  3. Infinite money as long as you keep driving
  4. Deliver passengers and get a bunch of money.

Expected behaviour A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Questions (please complete the following information):

Additional context N/A

spicebag commented 1 year ago

Expected behaviour A clear and concise description of what you expected to happen.

I expect the player to not get infinite money, either have a timer for delivery times etc.

S33G commented 1 year ago

Thanks for reporting, we'll take a look

NikoClapz commented 1 year ago

Thanks for reporting, we'll take a look

Any updates on this?

1llusiv3r commented 1 year ago

an easy fix would be to set a timer to countdown when you pickup the local, if after a certain time you don't drop off the passenger create a notification saying the passenger is calling the police and wants to be let out then send a dispatch notification for kidnapping or something with a description of the vehicle.

aymannajim commented 1 year ago

an easy fix would be to set a timer to countdown when you pickup the local, if after a certain time you don't drop off the passenger create a notification saying the passenger is calling the police and wants to be let out then send a dispatch notification for kidnapping or something with a description of the vehicle.

that's way too complicated, an easier fix could be changing this single line in server/main.lua from:

if randomAmount == r1 or randomAmount == r2 then Payment = Payment + math.random(10, 20) end

to this:

Payment = math.random(100, 500)

which will make the player get paid between $100 and $500, you can customize it as you wish.

github-actions[bot] commented 1 year ago

This issue has had 60 days of inactivity & will close within 7 days

KeeganAI commented 1 year ago

No, as i checked, it's based on the distance, if you move away from the delivery location, the total price will decrease.