qbcore-framework / qb-truckerjob

Trucker Job For QB-Core
GNU General Public License v3.0
32 stars 134 forks source link

Missing Store location #44

Closed NELXXDEV114 closed 1 year ago

NELXXDEV114 commented 1 year ago

Missing Store location for truck delivery

ChickenDipper1 commented 1 year ago

I DO NOT APPROVE I REWROTE A GOOD CHUNK OF QB-TRUCKER JOB TO MAKE IT WORK WITH QB-SHOPS AND THE SAME WITH QB-SHOPS!

Appreciate your work, but we do not all use QB-SHOPS, was also nice when you loaded the boxes into the van yourself to start with. Looks to have been removed..

Mane48 commented 1 year ago

I agree, just like ChickenDipper said, many people do not use qb-shops, I personally dont because i've found other scripts that are more thorough with the selling/shopping parts, I believe you should make and have the code be adaptive to whether the person is or isn't using qb-shops, a simple if Config.UsingQBShops then would fix a lot of these issues... Matter of fact, once I have time ill do it for you if you dont mind!

If you do and you think that you dont approve my idea then do the whole community a favor and just have it be an adaptive script instead of it depending solely qb-shops!

github-actions[bot] commented 1 year ago

This PR has had 60 days of inactivity & will close within 7 days