search

qbcore-framework / qb-vehiclesales

Player Vehicle Sales For QB-Core
GNU General Public License v3.0
31 stars 165 forks source link

Major UI refactor and code improvements #16

Closed steveski closed 3 years ago

steveski commented 3 years ago
  1. The screen layout was completely out on non standard aspect ratios such as 49" ultra wide monitors where the fields were rendered far left of the png form. I've removed the background pngs completely and now building the forms for sell and buy using html and css. Also made an SVG logo to try to make the forms look close to the original pngs.
  2. Business name for the form title is now set in the config file.
  3. Config file "Occasions" coordinate now converted to a table containing a vector which makes it cleaner to read and edit as well as a little less code to use these coords throughout the resource.
  4. Removed jQuery and using Vue.js to leverage two way model binding which makes the coding simpler to integrate with th UI. It's alot cleaner now to make changes ongoing.
  5. The entire charinfo object returned from QB was being passed to the form. The system now only sends to fields from charinfo that are required by the web form.
  6. When selling direct to the dealer a confirmation is displayed above the to ensure the palyer really wants to sell. Driving away from the zone will make it cancel. A thread is being created for the message and the deletion but once "cancel" is selected the thread completes to free up resources.
GhzGarage commented 3 years ago

Looks good except for the author line in the manifest

steveski commented 3 years ago

why even bother changing the manifest file?

Because there are new files to include and some removed. It also seemed appropriate to increment the version number.