qbcore-framework / qb-weathersync

Weather System Used With QB-Core :sun_behind_rain_cloud:
GNU General Public License v3.0
23 stars 144 forks source link

[SUGGESTION] More dynamic weather #58

Closed nzkfc closed 1 year ago

nzkfc commented 2 years ago

Is your feature request related to a problem? Please describe. Currently the weather changing seems to be non-existent, or so mild between states that it's hardly noticeable, despite the weather change timer set very low, between a 8-hour period.

Describe the feature you'd like I think the config/script just needs playing with a bit more, we set weather to change every 5 minutes just to see what happens, excpet during a 8 hour window between restarts, all we see is extrasunny, cloudy and occasionally fog. It never rains (maybe once a week if that, so we end up having to force change weather for variety.

Describe alternatives you've considered I remember an ollllld fork of qb-weathersync that made this much more dynamic, but I gave up bothering with maintaining it between default qb updates, so better to just enhance this one.

Additional context

w4fflz commented 2 years ago

You can make adjustments to the random weather selection in the server.lua file

Please advise if this request is still needed?

nzkfc commented 2 years ago

You can make adjustments to the random weather selection in the server.lua file

Please advise if this request is still needed?

That's a bandaid sort of answer to be fair, the point of suggestions is to enhance/fix things a script should already be doing via config (especially if pre-existing)

Yes I can go muck with the server.lua, but there is a config for this script and quite frankly it doesn't work as intended.

If we use all weather types, the most I see rain is when staff turn it on.... just doesn't make sense if rain is set to incredibly low by default.

Sorry if I sound rash, im just so over putting in enhancements to grow qb-core's scripts to make them better and every single dev just replies as if it's such a minor/small change and it's not worth their time. I get it, it's a low priority, however everything should still get it's time to be looked into.

CptNoHand commented 2 years ago

Agree

musictomy commented 1 year ago

Its annoying that other scrips and quite a few depend on this terrible script

nzkfc commented 1 year ago

It's not terrible, it just needs changing as it's extrasunny/cloudy/fog far too much and all the others are forced by staff because it doesn't change much.

On Thu, 15 Dec 2022, 5:54 am musictomy, @.***> wrote:

Its annoying that other scrips and quite a few depend on this terrible script

— Reply to this email directly, view it on GitHub https://github.com/qbcore-framework/qb-weathersync/issues/58#issuecomment-1351764805, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGHUHPMEGPQPGQHJ4ZMLSDWNH3TXANCNFSM56GI24NQ . You are receiving this because you authored the thread.Message ID: @.***>

nzkfc commented 1 year ago

Came back here to see if I had posted this issue, starting a fresh test server and left the config as XMAS and RAIN only in config, then set the change time to 2 minutes. Set default to RAIN.

Restarted server.

It rains for 2 minutes, then changes to cloudy, despite cloudy being off in config...

So yes weather changes seesms to be either ignoring config, or is doing something odd in the code.

github-actions[bot] commented 1 year ago

This issue has had 60 days of inactivity & will close within 7 days