qbic-pipelines / querynator

MIT License
1 stars 6 forks source link

update civicpy cache only when querying civic #22

Closed HomoPolyethylen closed 3 months ago

HomoPolyethylen commented 3 months ago

Fixes #21

PR Checklist

Description of changes

moved civic.load_cache(), which updated the civicpy cache into the query_civic() function. Thus it is not triggered through an import (as before) and hence only if civic is actually queried (and not when cgi is queried). Also added a logger info.

Technical details

Additional context

HomoPolyethylen commented 3 months ago

how does this fix the wildtype problem?

my bad. it does not. I had that in a separate PR, which I aborted. will open a new one. This PR will only prevent the civicpy cache to be updated when using cgi. It is a small PR but I thought the issues are not related enough to be combined. I could also add the wildtype fix here?

mapo9 commented 3 months ago

how does this fix the wildtype problem?

my bad. it does not. I had that in a separate PR, which I aborted. will open a new one. This PR will only prevent the civicpy cache to be updated when using cgi. It is a small PR but I thought the issues are not related enough to be combined. I could also add the wildtype fix here?

I will merge this one now to dev, then you can create the new one from the update dev