qbic-pipelines / querynator

MIT License
1 stars 6 forks source link

use cancer type in CIViC results #28

Closed HomoPolyethylen closed 3 months ago

HomoPolyethylen commented 5 months ago

PR Checklist

Description of changes

Technical details

Additional context

CGI and CIViC use different ontologies (CGI: OncoTree, CIViC: Disease-Ontology. Right now they need to be specified separately, passing the burden to map ontologies to the user. This should be attended to in the future. Let user specify one cancer type, querynator maps to OncoTree / DO, queries, ...

famosab commented 3 months ago

New changes look good to me.

Pytest seems to run into some kind of numpy error: ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

StackOverflow has a solution I think: https://stackoverflow.com/questions/78634235/numpy-dtype-size-changed-may-indicate-binary-incompatibility-expected-96-from

famosab commented 3 months ago

You'll need to fix the version of numpy to 1.26.4 for example (probably in the requirements file). https://github.com/qbic-pipelines/querynator/blob/2f24ccd990aafd280cbb04c0b6c921b0e87a5812/requirements.txt#L10