Closed mapo9 closed 1 year ago
master
branch :x:base
to dev
Hi @mapo9,
It looks like this pull-request is has been made against the mapo9/querynator master
branch.
The master
branch on qbic-pipelines repositories should always contain code from the latest release.
Because of this, PRs to master
are only allowed if they come from the mapo9/querynator dev
branch.
You do not need to close this PR, you can change the target branch to dev
by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.
Thanks again for your contribution!
Is the empty file querynator/cli_tools/cli_civic.py
needed? If not, please delete it.
Please check the formatting according to the linting
Could you please also add a query-api-civic
test for the cli?
Concerning tests: it would be really useful to have a dummy input files for each API query which can be used for testing to see how the output looks like. Could you think of solutions like creating a folder with tiny test input and output files?
Have you run black . && isort .
? This should fix the remaining linting errors
PR Checklist
docs
is updatedCHANGELOG.rst
is updatedDescription of changes