qbic-pipelines / querynator

MIT License
1 stars 6 forks source link

Civic api #7

Closed mapo9 closed 1 year ago

mapo9 commented 1 year ago

PR Checklist

Description of changes

github-actions[bot] commented 1 year ago

This PR is against the master branch :x:


Hi @mapo9,

It looks like this pull-request is has been made against the mapo9/querynator master branch. The master branch on qbic-pipelines repositories should always contain code from the latest release. Because of this, PRs to master are only allowed if they come from the mapo9/querynator dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page. Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

SusiJo commented 1 year ago

Is the empty file querynator/cli_tools/cli_civic.py needed? If not, please delete it.

SusiJo commented 1 year ago

Please check the formatting according to the linting

SusiJo commented 1 year ago

Could you please also add a query-api-civic test for the cli?

SusiJo commented 1 year ago

Concerning tests: it would be really useful to have a dummy input files for each API query which can be used for testing to see how the output looks like. Could you think of solutions like creating a folder with tiny test input and output files?

SusiJo commented 1 year ago

Have you run black . && isort .? This should fix the remaining linting errors