Closed luiskuhn closed 2 years ago
To keep the code consistent with lots of contributors, we run automated code consistency checks. To fix this CI test, please run:
markdownlint-cli
brew install markdownlint-cli
npm
then install markdownlint-cli
(npm install -g markdownlint-cli
)markdownlint . --fix
markdownlint .
Once you push these changes the test should pass, and you can hide this comment :+1:
We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!
Thanks again for your contribution!
I think we should be good to go.
We should just make sure the containers are properly built and pushed to qbicpipelines
when we merge into dev, and test again to make sure all processes function properly with the new containers.
Ok I think we tackled all the feedback. At this point, the only thing left is testing out the CI scripts and containers from qbicpipelines/
at dockehub. Since the containers are built and pushed on merge with dev, I will go ahead with this merge to test this, and if needed create another branch for clean-up and feedback from @ggabernet, hope that this is fine.
Initial prototype