search

qbicsoftware / postman-cli

A client software for dataset request and download from openBIS
MIT License
2 stars 1 forks source link

read in password with environment variable #86

Closed Aline-9 closed 2 years ago

Aline-9 commented 2 years ago

Many thanks for contributing to this project!

PR Checklist Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

Description of changes In class PostmanCommandLineOptions I added a new option to provide an environment variable name. In class App there was a new case added for reading in a password over the given env. variable name. These changes enable the user to provide their password over the env. variables instead of the command line. If the given env. variable doesn't exist, a message is printed and the user has the option to enter a password via the console.

Additional Notes The Documentation and the `CHANGELOG.rst are not updated yet

github-actions[bot] commented 2 years ago

Hi @Aline-9,

It looks like this pull-request is has been made against the qbicsoftware/postman-cli master branch. The master branch should always contain code from the latest release. Because of this, PRs to master are only allowed if they come from any qbicsoftware/postman-cli release or hotfix branch.

You do not need to close this PR, you can change the target branch to development by clicking the "Edit" button at the top of this page.

Thanks again for your contribution!