qbicsoftware / projectbrowser-portlet

QBiC Project Browser enables users to browse and manage their projects. Further, users can run analysis pipelines on registered data.
MIT License
0 stars 3 forks source link

Incorrect experiment code for "info experiment" #11

Closed wow-such-code closed 4 years ago

wow-such-code commented 5 years ago

https://github.com/qbicsoftware/projectbrowser-portlet/blob/08caca6c8aeff908e2110c0efef9acf101b6fa79/src/main/java/life/qbic/projectbrowser/controllers/DataHandler.java#L2220

There is an "E" too many, leading to some other problems. ExperimentCodeFunctions.getInfoExperimentID(space, projectCode) provides the correct experiment identifier.

An empty (at least) xml should be added as a property of the experiment: Map<String, Object> props = new HashMap<>(); String newDesignXML = ""; JAXBElement newDesignObject; try { newDesignObject = xmlParser.getEmptyXML(); newDesignXML = xmlParser.toString(newDesignObject); } catch (JAXBException e1) { e1.printStackTrace(); } props.put("Q_EXPERIMENTAL_SETUP", newDesignXML);

wow-such-code commented 5 years ago

correct info experiment code is now used in patient creation, but no xml property added, yet.

wow-such-code commented 5 years ago

Correct "empty" xml for IVAC projects is:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<qexperiment>
    <technology_type name="Genomics"/>
    <qfactors/>
</qexperiment>
wow-such-code commented 4 years ago

Has been fixed.