search

qbicsoftware / qoffer-portlet

QBiC offer generator aims to fulfill quotation preparation processes in a fully automatised fashion.
MIT License
0 stars 0 forks source link

Formatting Error for Prices #22

Closed jenniferboedker closed 5 years ago

jenniferboedker commented 5 years ago

When a price like 10.000€ is entered qOffer reads it as 10,000€ where the comma indicates the separation between Euro and Cents. In the generated offer the price also has a wrong format and the final sum could look like e.g. 183.600€ where this is the german notation but was entered in english notation.

jenniferboedker commented 5 years ago

The problem occurred because of unsuitable datatypes in the database. They have been changed from FLOAT to DECIMAL(11,2) for each column that represents a price (see here). In the code the queries had to be changed accordingly. Further problems have been noticed that might occurred through these changes:

  1. The discount is not correctly applied.

  2. When updating a price (like the internal price for a package) in the PackageManagerTab it is not updated in the OfferManagerTab for the offers that use that package. Also the total price for offers using that Package is not updated.

subwaystation commented 5 years ago

One possible error we suspect is that we did not change all FLOATs to DECIMALs in the code. Maybe @jenniferboedker you can inspect that further?

jenniferboedker commented 5 years ago

Solved with #26