search

qbittorrent / qBittorrent-website

qBittorrent website
https://www.qbittorrent.org
181 stars 111 forks source link

Allow clicks through version ribbon's span #154

Closed Poopooracoocoo closed 3 years ago

Poopooracoocoo commented 3 years ago

ahah! so you use pointer events!

Chocobo1 commented 3 years ago

Can you explain what does it do? I tested it but didn't found anything different.

I see you mentioned the problem in #149:

When I tried making the header image fit the width for smaller widths, the height would shrink and the ribbon took up the same amount of space while the menu moved up. This meant that the first few menu items couldn't be accessed! I solved this by making the height stay the same. It could've been solved by changing the ribbon so that clicks go through as there's enough space. https://github.com/simonwhitaker/github-fork-ribbon-css does it better than https://github.com/codepo8/css-fork-on-github-ribbon IMO, but I'm sure there's a way to fix up the current one. Edit: Fixed it with pointer-events!

Poopooracoocoo commented 3 years ago

This isn't necessary but is a better foundation, per se. As in it doesn't fix anything right now but any further modifications could potentially benefit, I suppose. ¯\_(ツ)_/¯

Chocobo1 commented 3 years ago

@Poopooracoocoo Thank you!