qbittorrent / qBittorrent-website

qBittorrent website
https://www.qbittorrent.org
186 stars 106 forks source link

Static Website Pre-Rendered at build #169

Closed LordKa0S closed 4 months ago

LordKa0S commented 3 years ago

Live

Why

This site makes a pretty good argument for static sites. Further, costs are reduced with no server-side execution. The webpack build ensures that only the necessary assets are exposed (example exposed asset on the current site).

The Good

Site feels much snappier, and is confirmed by PageSpeed Insights and web.dev Measure. Below are the results comparing the news page, which has the most content:

Mobile

Current

image

Proposed

image

Desktop

Current

image

Proposed

image

The Bad

So far, I've found only one issue: on both desktop and mobile, the menu section is not exactly the same as the current site.

I've tried comparing diffs of the stylesheet and the markup after they've loaded into the browser, and they seem to be exactly the same. If someone finds out what's changed, feel free to let me know in the comments.

Update: Fixed in 864a426

Disclaimer

I know that this is an attempt at solving a non-issue. I stumbled across this repo browsing for a BitTorrent client for my device, and found the complexity to be just enough for me to have a go at what I believe to be improvements. That said, I completely understand if the contributors to this project are not comfortable with the complete architecture change I'm proposing. I'd appreciate constructive review of my changes, even if they're not ultimately merged.

Poopooracoocoo commented 3 years ago

@Chocobo1 have you seen this?

LordKa0S commented 4 months ago

It seems @sledgehammer999 performed something similar in https://github.com/qbittorrent/qBittorrent-website/commit/7092ba7619792fea3124c0a338ded874b5974e8a, nearly 2 years after I proposed this. While I believe it's a step in right direction for the development of the website, I'm disappointed in how community contributions to the project are treated.