qbittorrent / qBittorrent-website

qBittorrent website
https://www.qbittorrent.org
181 stars 110 forks source link

Use lossless banner #64

Closed adem4ik closed 6 years ago

adem4ik commented 6 years ago

The existing banner is overcompressed, so it has a lot of artficats and it doesn't look good on the front page. I've decided to make it less compressed using the old png-file. File size has been increased too from 27 KiB to 60 KiB. Here is the comparison in 200% zoom (existing vs new): comparison

Chocobo1 commented 6 years ago

How about making a lossless banner (in png format)? The save in filesize doesn't matter much nowadays.

adem4ik commented 6 years ago

@Chocobo1 Sure, I can make one by replacing qb_newbanner.png. Should I make a new PR or update this one?

Chocobo1 commented 6 years ago

Should I make a new PR or update this one?

You can reuse this one. Oh, and it would be best to make it a new file instead of overwriting the old banner.

adem4ik commented 6 years ago

@Chocobo1 I can rename old qb_newbanner.png to qb_oldbanner.png and add new qb_newbanner.png. Is if fine?

Chocobo1 commented 6 years ago

@Chocobo1 I can rename old qb_newbanner.png to qb_oldbanner.png and add new qb_newbanner.png. Is if fine?

OK.

Chocobo1 commented 6 years ago

A few suggestions:

adem4ik commented 6 years ago

I have no idea how to remove commits or squash them.

Chocobo1 commented 6 years ago

It can be done in console:

git rebase -i HEAD~4
# mark commits as fixup or remove commit
git push -f  # then force push to update the branch

Or I can help you do it, if you don't mind.

sledgehammer999 commented 6 years ago

FYI, I am ok with the change. You can merge it when you fix the commit issue.

adem4ik commented 6 years ago

I've removed all the previous commits, added a new one according to the suggestions.

Chocobo1 commented 6 years ago

Thank you!

... some how after pressing the merge button I suddenly remember it is possible to further compress the png with tools like PNGGauntlet... I will make a follow up commit.