search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
26.83k stars 3.87k forks source link

qbittorrent-4.1.5 does not link with libtorrent-rasterbar-1.2.0 #10199

Closed slashbeast closed 5 years ago

slashbeast commented 5 years ago

Please provide the following information

qBittorrent version and Operating System

4.1.5, Gentoo ~amd64

If on linux, libtorrent and Qt version

libtorrent 1.2.0, QT 5.11.3

What is the problem

qbittorrent does not link with libtorrent-rasterbar 1.2.0 library.

base/bittorrent/infohash.cpp:44:43: error: invalid operands of types ‘libtorrent::digest32<160>::difference_type() noexcept’ {aka ‘long int()’} and ‘int’ to binary ‘operator*’
 char out[(libtorrent::sha1_hash::size * 2) + 1];

What is the expected behavior

That I can link the binary against latest libtorrent-rasterbar 1.2.0

Steps to reproduce

  1. Bump libtorrent-rasterbar to 1.2.0
  2. Compile and link qbittorrent

Extra info(if any)

(type here)

WolfganP commented 5 years ago

AFAIK libtorrent 1.2.0 support is in progress (as per https://github.com/qbittorrent/qBittorrent/pull/9704) As per wiki instructions, I'm using RC_1_1 (https://github.com/arvidn/libtorrent/commits/RC_1_1) for building qB master branch. I hope it helps.

slashbeast commented 5 years ago

Sure, I can link qbittorrent against older library with no problem, just wanted to report it, I was not sure there's a work in progress on that. Should I close this bug report, or should I somehow linke it to #9704?

sledgehammer999 commented 5 years ago

This isn't a bug. It just doesn't support RC_1_2.

glassez commented 5 years ago

It's not the bug. libtorrent-1.2 isn't supported currently.

yurivict commented 5 years ago

Do you know when will libtorrent-1.2 be supported? libtorrent-1.1.10 isn't compatible with the latest boost: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236588

sledgehammer999 commented 5 years ago

@yurivict FYI, there's 1.1.12 in the 1.1.x series. About 1.2.x compatibility: see #10373

Noctem commented 5 years ago

I did a quick and dirty backport of #10373. It's completely unofficial and unsupported, so if you do try it don't create any issues about it here. There could easily be errors and/or omissions.

edit: It seems to be reporting all torrents to their trackers as leeching rather than seeding, regardless of whether they are complete or not. I don't have time to figure out why that is or fix it, but if someone else does you could let me know.

yurivict commented 5 years ago

I can't try it because libtorrent isn't compatible with boost.

xnoreq commented 5 years ago

I can't try it because libtorrent isn't compatible with boost.

Using boost 1.69.0 and libtorrent git RC_1_1 here without any problems.