search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
27.5k stars 3.91k forks source link

RSS re-downloads complete items #1055

Closed jonas418 closed 3 years ago

jonas418 commented 10 years ago

As far as I can tell qBittorrent is re-adding things from RSS when a download has completed and been removed from the download list. Would be good if it did not add the same things over and over again which is already completed.

Not sure how this would work, but maybe a downloaded item should be marked as read and make the RSS reader not trigger on articles marked as read.

According to my execution log qBittorrent is trying to re-download the same thing at least once per hour even though the item is already either in the download list or removed after being downloaded.

sledgehammer999 commented 10 years ago

Which version are you using and which OS?

jonas418 commented 10 years ago

qBittorrent 3.1.1.1, win7 x64.

Also since I upgraded to 3.1.1.1 (was using v 3.0.11 before) I have noticed a massive change to performance. V3.1.1.1 lags and freezes a lot. But thats a separte issue which I probably should file a new bug about.

sledgehammer999 commented 10 years ago

@jonas418 can you use v3.1.0 for comparison?

http://sourceforge.net/projects/qbittorrent/files/qbittorrent-win32/qbittorrent-3.1.0/qbittorrent_3.1.0_setup.exe/download

jonas418 commented 10 years ago

I've tried 3.1.0 now and the problem is still there. I have managed to narrow down the problem a bit further. The lag occurs when qBittorrent is refreshing the RSS feeds. For verification I put the RSS refresh time down to 1 minute and waited. When the refresh starts qBittorrent hogs one of the CPU threads and uses 13% of the total CPU power (I have an 8 core CPU). The refresh takes about 30 seconds to perform, and during that time qBittorrent is not responding at all. When it finally responds I only have roughly 30 seconds to use qBittorent until the next refresh occurs on the RSS feeds. If I switch the refresh time to 10 minutes the problem only occurs every 10 minutes.

I'm not a programmer my self so I don't know anything about the code or under the hood. But would it be possible to put the RSS fetcher in a separate thread and let the GUI work normally during that time?

Thank you for your help so far!

sledgehammer999 commented 10 years ago

@jonas418 and @ketamin

What is the RSS feed that causes this problem? If it is private, please email me the .xml/feed file to sledgehammer999 at qbittorrent dot org

ldrick commented 10 years ago

@sledgehammer999 Thank you, I've send you the feed.

papampi commented 10 years ago

None of my rss feeds marked read after they downloaded ,

ubuntu 13.10 , qbittorrent 3.1.0

sledgehammer999 commented 10 years ago

@papampi Your problem seems similar to #998 which is fixed in 3.1.1 already.

papampi commented 10 years ago

problem is there is no 3.1.1 in ppa for ubuntu look here : https://launchpad.net/~hydr0g3n/+archive/qbittorrent-stable/

in Latest updates its written : Failed to build: amd64 i386

sledgehammer999 commented 10 years ago

I know, I have informed the person who maintains it but he hasn't responded. You could use the same PPA but for 13.04 instead.

papampi commented 10 years ago

Thnx I just added raring ppa to my sources.list and now i have 3.1.3

for others just change saucy from /etc/apt/sources.list to raring like this :

deb http://ppa.launchpad.net/hydr0g3n/qbittorrent-stable/ubuntu raring main deb-src http://ppa.launchpad.net/hydr0g3n/qbittorrent-stable/ubuntu raring main

Nekotje commented 10 years ago

Hi im using version 3.1.8 for windows. Im using windows 7 64 bit. i have the same problem.

a torrent was completed and removed and it did redownload it again time after times already for 8 times now.

thing is also it also just redownloads the complete file. it doesnt check the directory where the file is moved if the file is there and hash it from there either. This isnt very handy for people with limited Bandwidth.

Maybe there can be a list of filenames that are already downloaded.

Nekotje commented 10 years ago

using 3.1.9 for windows now. and use multiply feeds some have the same entries but different urls sometimes.When it adds 1 from the feed that i setup a filter for it downloads them both. If the download url is the same it says already in list but when the url is different but filename is the same it just adds it again.

Nekotje commented 9 years ago

i have downloaded http://qbforums.shiki.hu/index.php/topic,2344.msg15066.html#msg15066 the latest one. 3.2.0

http://puu.sh/hahd4/024f39bcae.png it does keep downloading the same torrent like 30 times.

sledgehammer999 commented 9 years ago

@Nekotje FYI we have beta builds now: http://qbforums.shiki.hu/index.php/topic,3310.msg16116.html#msg16116

Nekotje commented 9 years ago

Yes i just downloaded and installed qbittorrent_3.2.0alpha_20150308_19b9a84_setup.exe

so i have to see if it still happens on that one. But all rss feeds show a red X icon.

Edit: qbittorrent_3.2.0beta_20150329_c6bfcd0_setup.exe has the same problem

pricejt commented 8 years ago

I am having this issue on v3.3.3 it keeps downloading two of my files coming from RSS. It doesn't do it for all the files.

ericgur commented 6 years ago

I have the same issue using 3.3.16 x64 (and at least 2 previous builds) on Windows 10 RS2 and RS3. I'm using an RSS from showrss (this is my personal show feed): http://showrss.info/user/24224.rss?magnets=true&namespaces=true&name=null&quality=null&re=null

Only for some files exist in the feed, qBitTorrent will show some extremely high number (4 billion+) for both the feed tab and the unread tab. This number looks like a negative 32bit number converted to unsigned.

Deleting the downloaded files from disk will cause qBitTorrent to download them again and again until those files are not part of the RSS feed.

The files that cause this issue right now are: Designated.Survivor.S02E05.720p.HDTV.x264-KILLERS[rarbg] Mr.Robot.S03E03.720p.HDTV.x264-AVS[rarbg] Screenshot attached.

qbittorrent_rss_issue

sledgehammer999 commented 3 years ago

This issue has been closed and locked for being too old, and thus either most likely resolved in recent versions or no longer applicable. If you experience the reported problem or similar in the latest version, please open a new issue report with the requested information in the issue template.

A new issue report with relevant updated data gathered from the latest version is preferable to necroing an old report with a comment like "still happens in version x.y.z", even if you think the bug is the same, or suspect of a regression. Due to the changes made to the qBittorrent code and its dependencies over time, the exact cause of your problem could be totally different than the original one, despite the visible symptoms of the bug being similar. Thus, providing relevant updated information is crucial to find and fix the root cause of a recurrent problem or regression.

Thank you for your contributions.