search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.23k stars 3.97k forks source link

'Use proxy only for torrents' can be misinterpreted #11457

Open God-damnit-all opened 5 years ago

God-damnit-all commented 5 years ago

Originally, I had figured this meant 'For torrents, only use the proxy', which I assumed to mean tracker operations and retrieving metadata, instead of only using it for peer exchange. But, I've come to learn that it actually means 'Only for torrents, use the proxy'.

Perhaps 'Limit proxy use to torrents'?

retrocaster commented 3 years ago

I agree that this setting should be renamed for better clarity. The official Torguard and Private Internet Access guides for SOCKS5 setup suggest enabling it and I suspect it's because they're misinterpreting the intent.

What exactly is the reason why a user would want to enable this? Maybe it could be reworded to describe that use case more specifically, such as "Limit proxy use to torrents. Enabling this will bypass the proxy for rss and search operations." Do I understand the intention correctly? I'm still not sure I understand why this is a useful setting.

edit: I found this description for the functionality: "RSS feeds, search engine, software updates or anything else other than torrent transfers and related operations (such as peer exchanges) will use a direct connection" from here: https://github.com/qbittorrent/qBittorrent/blob/60d65d8137874bf5a832486d423ca64c0a9467f9/src/gui/optionsdialog.ui That description really helps but the problem is that it doesn't show up anywhere I can find within the web ui.

Ted-Barrett commented 1 year ago

Have made an attempt at modifying the phrasing to fix this issue, as in the above fork. My first time contributing but have tried to follow all the guidelines as accurately as possible. Thanks.

thalieht commented 1 year ago

Have made an attempt at modifying the phrasing to fix this issue, as in the above fork.

I don't know about the re-phrasing itself but as for the code you only need the change in optionsdialog.ui and preferences.html. Everything else needs to be reverted.

Ted-Barrett commented 1 year ago

Adjusted for capitalisation of RSS as suggested here

kang000feng commented 1 year ago

Have made an attempt at modifying the phrasing to fix this issue, as in the above fork.

I don't know about the re-phrasing itself but as for the code you only need the change in optionsdialog.ui and preferences.html. Everything else needs to be reverted.

Dear contributor,

Good day. May I ask if I disable this "use proxy only for torrents" and enable both "use proxy for peer connections" and "use proxy for host name lookup" , all the network traffics of Qbittorrent will use proxy ? If answer is no, then what should I do to make all the network traffics from Qbittorrent to use proxy. Btw my proxy protocol is socks5.

tdworz commented 5 months ago

I'm here due to this confusion.

Ty-Manning commented 4 months ago

I agree this needs to be changed. At first I interpreted this as being a good thing, something similar to "force proxy connection" but I now am struggling to find a reason why anyone would want to enable this setting.

alaneuler commented 1 week ago

I'm here also due to this confusion, and found out the documents link here is obsolete: https://github.com/qbittorrent/qBittorrent/wiki/Explanation-of-Options-in-qBittorrent#user-content-Proxy_server (first link under Proxy server)