Download folder custom attributes are deleted (desktop.ini)

PaulCoddington commented 5 years ago

qBittorrent version and Operating System

qBittorrent 4.2.0 on Windows 10 Pro x64 1909

What is the problem

If the folder for downloads is a customised folder, with custom icon and/or customised display attributes, qBittorrent will delete the hidden desktop.ini file when deleting torrents and files removing all customisations.

What is the expected behavior

qBittorrent should not delete a hidden system file that determines folder attributes.

Steps to reproduce

In qBittorrent right click on the completed download and select Delete.
Enable checkbox "Also delete files on the hard disk", press the OK button.

Extra info

Raises question whether other non-torrent related files in the download folder are also deleted.

Some users may attempt to store data related to torrenting activities in the downloads folder on the assumption that torrents will always be contained in subfolders (most are, but not all). If files are deleted, new users might end up learning this the hard way.

sledgehammer999 commented 4 years ago

@PaulCoddington can you try the following test build and tell me if it fixes your problem? It contains the fix I have put in PR #11661. Either run the file from any folder or overwrite the official files. Link: http://builds.shiki.hu/temp/qbittorrent_4.2.0_x64_patched_for_issue_11575.7z

ArcticGems commented 4 years ago

This should be fixed in the new qBittorrent 4.2.1!! :smile:

BUGFIX: Don't unnecessarily delete OS files in folders (sledgehammer999)

xavier2k6 commented 3 years ago

OP disappeared & issue should be fixed as of 4.2.1

qbittorrent / qBittorrent