qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
26.35k stars 3.85k forks source link

Bring back buttons in search-widget #12846

Open coolio2013 opened 4 years ago

coolio2013 commented 4 years ago

Since v4.2.0, buttons for 'Download', 'Go to description page' and 'Copy description page URL' of the search widget have been removed and replaced by the context menu only (#10852).

At least the first 2 buttons are the most important UI elements for a search and DO something. It does not make any sense to move these functions to the context menu only, imho. More clicks are required, too. The far less used button 'Copy' was extended by the new context menu and could remain omitted.

I find it odd that there has not been any discussion. No offense @Chocobo1!

If you look at other fully featured clients like BiglyBT, qbt is nearly naked and lacking lots of features. Removing functions isn't a good idea. And imagine a new user looking at the search widget: 'Uhh, what is that for? No buttons to click, except search? Why that?'

TL;DR: Please bring back buttons 'Download' and 'Go to description page'. Context menu could remain as it is now.

FranciscoPombal commented 4 years ago

TL;DR: Please bring back buttons 'Download' and 'Go to description page'. Context menu could remain as it is now.

I think this seems reasonable. Given the importance of this buttons, I think they should not be hidden away in the context menu. @Chocobo1 thoughts?

If you look at other fully featured clients like BiglyBT

Bloated != Fully featured :)

Chocobo1 commented 4 years ago

And imagine a new user looking at the search widget: 'Uhh, what is that for? No buttons to click, except search? Why that?'

This was the rational at that time: Transfer list widget doesn't provide buttons either and users are expected to open right-click menu for various tasks. Search widget was adjusted to be consistent with this concept. Also having the exact same buttons and menu items seems duplicative.

@Chocobo1 thoughts?

Please don't double ping me (OP already had). I'm not looking for further discussion on this... Just to be clear, that doesn't mean I insist on my viewpoint (nor intend to block any related PR), just not interested anymore.

coolio2013 commented 4 years ago

For pause, resume, etc, the transfer list does provide

It makes sense to keep less frequently used actions in the context menu in order not to blow up the GUI with buttons. There should be always good reasons to remove some UI element, which has existed before and proved to be useful. I was just surprised to see the buttons go in search widget as I was used to them.

qarkai commented 3 years ago

+1 for buttons return. It's impossible to download on devices without right-click support, e.g. SmartTV.