Negative peers values in GUI

covako commented 3 years ago

Please provide the following information

qBittorrent version and Operating System

4 3 0 1 , x64 win10 1809 10.0.17763

If on linux, libtorrent-rasterbar and Qt version

(type here)

What is the problem

Negative peers values

What is the expected behavior

I dont know, just add (and remove with files) torrent several times, because QBT wont scrap leechers and seeds from torrent - trackers URL

Steps to reproduce

1.add torrent, a

after 30 secs or less remove it from qbt with files from disk
repeat several times^

Extra info(if any)

(type here)

covako commented 3 years ago

screenshot:

MJUvQUk

~https://i.imgur.com/MJUvQUk.png~

xavier2k6 commented 3 years ago

@covako did you mean peers with negative values & not seeds as your screenshot shows peers?

covako commented 3 years ago

@covako did you mean peers with negative values & not seeds as your screenshot shows peers?

sorry, typo. I mean peers ofc

pekatron9000 commented 3 years ago

same problem. when i delete tracker in private torrent, peers counter changes to negative value and downloading is stopped. this has never happened in previous versions

thalieht commented 3 years ago

@covako the torrents you've encountered with this problem are private or there is at least one public?

mblazic commented 3 years ago

Same issue here with private torrents on qBittorrent client, version 4.3.0.1, running on GNU/Linux CentOS 7.8.2003 (docker container).

covako commented 3 years ago

@covako the torrents you've encountered with this problem are private or there is at least one public?

Yes, its bug for a private torrent. Just tested

thalieht commented 3 years ago

It seems to only affect private torrents so i suspect it's because of the new libtorrent's clear_peers we introduced in 4.3.0 for private torrents. https://github.com/qbittorrent/qBittorrent/blob/61770ad69edea4a59d1597a4081a36532f16de15/src/base/bittorrent/torrenthandleimpl.cpp#L376-L377

https://github.com/qbittorrent/qBittorrent/blob/61770ad69edea4a59d1597a4081a36532f16de15/src/base/bittorrent/torrenthandleimpl.cpp#L915-L918

Looks like list_seeds > list_peers at some point. ~~I don't know if qBt or libtorrent is supposed to clear them from fastresume.~~ @glassez @Chocobo1 any thoughts?

Chocobo1 commented 3 years ago

It seems to only affect private torrents so i suspect it's because of the new libtorrent's clear_peers we introduced in 4.3.0 for private torrents.

https://github.com/qbittorrent/qBittorrent/blob/61770ad69edea4a59d1597a4081a36532f16de15/src/base/bittorrent/torrenthandleimpl.cpp#L376-L377

https://github.com/qbittorrent/qBittorrent/blob/61770ad69edea4a59d1597a4081a36532f16de15/src/base/bittorrent/torrenthandleimpl.cpp#L915-L918

Looks like list_seeds > list_peers at some point. ...

@arvidn Does the above sounds like a bug in libtorrent?

Ryrynz commented 3 years ago

@arvidn is this still an issue?

Dorno commented 3 years ago

This still occurs for me in Qbit 4.3.8 running in Docker on a NAS. If I pause the torrent and change the tracker, say from http to https or vice versa upon starting the torrent again I get a negative number of peers.

ghost commented 2 years ago

Could not reproduce it on 4.4.3.1. Is anyone still able to reproduce?

unregd commented 2 years ago

4.4.3.1, win10, private torrent, negative peers just appeared for me, I haven't seen this before. I've deleted the same non-responding tracker from all my running torrents, but only one of them shows Peers 0(-1).

xavier2k6 commented 1 year ago

@unregd Can you reproduce with qBittorrent 4.5.4 (libtorrent 1.2.x/libtorrent 2.0.x) versions?

unregd commented 1 year ago

I haven't noticed it since that one particular occurence. Even that was completely random. Only one of many torrents using the same, one tracker showed it.

luzpaz commented 1 month ago

Is this ticket still relevant ?

luzpaz commented 3 weeks ago

@xavier2k6 should we close ?

qbittorrent / qBittorrent