search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.63k stars 4.01k forks source link

Portuguese Language #14057

Open hugok79 opened 3 years ago

hugok79 commented 3 years ago

The qbittorrent_pt.ts lang file is missing in /src/lang/ and the webui_pt.ts is missing in /src/webui/translations/. However in pt_PT.ts files the language code that appears is pt:

TS language="pt" version="2.1"

In Transifex I have kept the pt 100% translated but here you can only find the pt_PT file that is incomplete in Transifex. In the meantime I have already made a request to join the pt_PT team in Transifex because at the moment it is without translators/coordinators/reviewers.

Note: Portuguese can use both pt and pt_PT language code, Both are used for the Portuguese used in Portugal.

FranciscoPombal commented 3 years ago

@hugok79

Apologies, this slipped under my radar.

The qbittorrent_pt.ts lang file is missing in /src/lang/ and the webui_pt.ts is missing in /src/webui/translations/. However in pt_PT.ts files the language code that appears is pt:

TS language="pt" version="2.1"

In Transifex I have kept the pt 100% translated but here you can only find the pt_PT file that is incomplete in Transifex.

Note: Portuguese can use both pt and pt_PT language code, Both are used for the Portuguese used in Portugal.

I am not too familiar with the mechanics of Qt translations, so please bear with me.

Are you suggesting we should create new files under src/lang and src/webui/www/translations named .*pt.ts and change the <TS version="2.1" language="pt"> lines in the existing .*pt_PT.ts files to <TS version="2.1" language="pt_PT">, or am I misunderstanding the issue?

In the meantime I have already made a request to join the pt_PT team in Transifex because at the moment it is without translators/coordinators/reviewers.

I have accepted you into the team as a Coordinator.

hugok79 commented 3 years ago

Olá @FranciscoPombal

I am also not a programmer or anything like that, I just do translations for Portuguese.

However I have been doing translations for 13 years, mainly for Linux and as such I am already familiar with translations.

"Are you suggesting we should create new files under src/lang and src/webui/www/translations named .pt.ts and change the lines in the existing .pt_PT.ts files to , or am I misunderstanding the issue?"

No, you got it right.

Yes, I am already a translator/coordinator/reviewer of the the pt_PT team, thank you. In the meantime I have already complete the pt_PT translations. Portuguese(Portugal) is fully translated now.

The translations are automatically synchronized from Transifex, aren't they?

FranciscoPombal commented 3 years ago

Olá @hugok79

The translations are automatically synchronized from Transifex, aren't they?

Unfortunately, no. It seems @sledgehammer999 does it by hand every once in a while: https://github.com/qbittorrent/qBittorrent/search?q=transifex&type=commits. Perhaps "semi-automatically" would more accurately describe it. I'm not sure if he's the only one who has permissions to do it, and I'm also not sure if new files need to be added manually or if the sync procedure covers that as well.

Currently, I don't know enough about the procedure to know how to improve it. However, two things are obvious to me, in terms of what we should aim to achieve in order to improve it, at a high level:

  1. more than one person should be able to do it - this way, we don't depend on the availability of a single member get updated translations into the repo.
  2. ideally, the procedure should be automated. Such automation could be implemented via GitHub Actions and run maybe every 2 weeks, or when a contributor with commit access activates some kind of trigger.

@sledgehammer999 @glassez @Chocobo1

FranciscoPombal commented 3 years ago

NOTE for other devs: I just saw https://github.com/orgs/qbittorrent/teams/bug-handlers/discussions/10/comments/23. I'll fix the mishap tomorrow.

hugok79 commented 3 years ago

Most of the projects that I translate in platforms like Transifex, Weblate, Crowdin, Zanata, Launchpad, Damned Lies(Gnome DE) etc.. are automatically synchronized by the platforms...

hugok79 commented 2 years ago

@sledgehammer999 Just one observation, although both the pt and pt_PT translations are the same and correspond to the language of Portugal, why is it that only pt_PT is loaded/used in qBittorrent/src/lang and qBittorrent/src/webui/www/translations if in Transifex both languages exist?

luzpaz commented 1 year ago

Is this still a relevant issue ?

hugok79 commented 1 year ago

In technical terms I don't know, but when it comes to translation, I just don't want to have to do extra work when we can only have one language, in this case, Portuguese (Portugal) (pt_PT)