search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
27.39k stars 3.9k forks source link

qBt uploading two times to one peer who is running 2 bittorrent clients on same IP #14313

Open slrslr opened 3 years ago

slrslr commented 3 years ago

Please provide the following information

qBittorrent version and Operating System

4.3.3

Issue

I want one remote IP being able to download multiple torrents from me. This is possibly disabled by default, but i enabled it: Session\MultiConnectionsPerIp=true

at same time i do NOT want one IP download one torrent multiple times at once. Some person is using two different torrent clients to download huge torrent, likely into same location (client likely silently overwriting data because it does not assume it could change without it knowing). So i want to prevent this waste.

Solution? A) by default qbittorrent will not allow one torrent to upload two times to single remote IP (like now is happening to me in v.4.3.3) B) allow user not to ban just IP from the Peers tab, but IP:port combination(i know it is less effective) or IP and peerID combination - more effective, not just IP alone?

thalieht commented 3 years ago

I haven't tested it but the following quote makes sense to me, logically.

https://github.com/qbittorrent/qBittorrent/issues/5884#issuecomment-307874988 Even without this option, you can have the same ip connected multiple times, limited to 1 per torrent.

LazyPajen commented 3 years ago

I would like to add this: There are lots of "Seed boxes" that you can hire that different users share the same IP with different clients Maybe this is something you have encountered

slrslr commented 3 years ago

@LazyPajen part of the seedboxes add client dedicated IP, yet if they use same IP, they have different port i guess. So the IP/port combination or IP&peerID basis, then it is ultra low risk of blocking user download, because it is unprobable that within single seedbox there will be 2 users downloading same thing at same time. And even if does, then after first user complete download, second one will be allowed. So in summary, i do not think this is problem - moreover as i have mentioned, i believe that qbt by default disallows multiple connection from single IP. Maybe this default behavior can be changed after is implemented feature 1IP/1 torrent.

Seeker2 commented 3 years ago

Seedboxes sharing the same ip may connect pretty quickly to each other -- even if they have to go through the internet connection, their low latencies might allow them to achieve close to max line speeds. (Especially if their settings are optimized for their connection!)

You might not get much chance to upload to more than one as a result.

The5kull commented 3 years ago

I haven't tested it but the following quote makes sense to me, logically.

#5884 (comment) Even without this option, you can have the same ip connected multiple times, limited to 1 per torrent.

With the option "Allow multiple connections from the same IP adress" UNCHECKED I do see the same IP on different torrents downloading but I have never seen the same IP twice downloading the same torrent like OP mentioned. So your linked comment is libtorrent working as intended and not an issue.