qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
26.99k stars 3.88k forks source link

Error building Qbittorrent-nox debian 10 package with checkinstall #15469

Closed sbocquet closed 2 years ago

sbocquet commented 3 years ago

Description

qBittorrent info and operating system(s)

What is the problem

When building the qBittorrent-nox package as describe in this page (https://github.com/qbittorrent/qBittorrent/wiki/Compilation:-Debian-and-Ubuntu), the package is not created. It used to work with prior versions (4.3.3 for example)

Detailed steps to reproduce the problem

  1. git clone https://github.com/qbittorrent/qBittorrent
  2. git checkout release-4.3.8
  3. cd qBittorrent
  4. ./configure CXXFLAGS="-std=c++17" --disable-gui
  5. make -j$(nproc)
  6. checkinstall --nodoc --backup=no --deldesc --pkgname qbittorrent-nox --pkgversion 4.3.8 --maintainer stephane@mymail.fr

What is the expected behavior

Building the .deb package

Extra info (if any)

Attachments

checkinstall 1.6.3, Copyright 2010 Felipe Eduardo Sanchez Diaz Duran This software is released under the GNU GPL. Please write a description for the package. End your description with an empty line or EOF.

bittorrent client based on libtorrent-rasterbar (without X support)


* Debian package creation selected


This package will be built according to these values:

0 - Maintainer: [ stephane@mymail.fr ] 1 - Summary: [ bittorrent client based on libtorrent-rasterbar (without X support) ] 2 - Name: [ qbittorrent-nox ] 3 - Version: [ 4.3.8 ] 4 - Release: [ 1 ] 5 - License: [ GPL ] 6 - Group: [ checkinstall ] 7 - Architecture: [ amd64 ] 8 - Source location: [ qBittorrent-4.3.8 ] 9 - Alternate source location: [ ] 10 - Requires: [ ] 11 - Recommends: [ ] 12 - Suggests: [ ] 13 - Provides: [ qbittorrent-nox ] 14 - Conflicts: [ ] 15 - Replaces: [ ]

Enter a number to change any of them or press ENTER to continue:

Installing with make install...

========================= Installation results =========================== cd src/ && ( test -e Makefile || /usr/lib/qt5/bin/qmake -o Makefile /usr/local/src/qBittorrent-4.3.8/src/src.pro -qtconf /usr/lib/x86_64-linux-gnu/qt5/qt.conf -early QMAKE_CC=x86_64-linux-gnu-gcc QMAKE_CXX=x86_64-linux-gnu-g++ QMAKE_LINK=x86_64-linux-gnu-g++ QMAKE_QMAKE=/usr/bin/x86_64-linux-gnu-qmake PKG_CONFIG=x86_64-linux-gnu-pkg-config -before QMAKE_LRELEASE= ) && make -f Makefile install make[1]: Entering directory '/usr/local/src/qBittorrent-4.3.8/src' /usr/lib/qt5/bin/qmake -install qinstall /usr/local/src/qBittorrent-4.3.8/doc/qbittorrent-nox.1 /usr/local/share/man/man1/qbittorrent-nox.1 Error copying /usr/local/src/qBittorrent-4.3.8/doc/qbittorrent-nox.1 to /usr/local/share/man/man1/qbittorrent-nox.1: Cannot create /usr/local/share/man/man1/qbittorrent-nox.1 for output make[1]: [Makefile:13741: install_man] Error 3 (ignored) /usr/lib/qt5/bin/qmake -install qinstall -exe qbittorrent-nox /usr/local/bin/qbittorrent-nox Error copying qbittorrent-nox to /usr/local/bin/qbittorrent-nox: Cannot create /usr/local/bin/qbittorrent-nox for output make[1]: [Makefile:13750: install_target] Error 3 (ignored) strip /usr/local/bin/qbittorrent-nox strip: '/usr/local/bin/qbittorrent-nox': No such file make[1]: [Makefile:13751: install_target] Error 1 (ignored) make[1]: Leaving directory '/usr/local/src/qBittorrent-4.3.8/src'

======================== Installation successful ==========================

Copying files to the temporary directory...OK

Stripping ELF binaries and libraries...OK

Compressing man pages...OK

Building file list... FAILED!

Building Debian package...OK

NOTE: The package will not be installed

Erasing temporary files...OK

Deleting temp dir...OK


Done. The new package has been saved to

/usr/local/src/qBittorrent-4.3.8/qbittorrent-nox_4.3.8-1_amd64.deb You can install it in your system anytime using:

  dpkg -i qbittorrent-nox_4.3.8-1_amd64.deb

sbocquet commented 3 years ago

Hi,

Also found this topic on checkinstall which seems to be the same problem. https://askubuntu.com/questions/1014619/a-working-version-of-checkinstall

But if that's the case, why did it work before ?

WolfganP commented 3 years ago

Workaround: I also had issues with my builds on a Raspberry Pi since the switch to Qt v5.15+, but instead of tweaking the install environment I decided to keep qBt updated via the official PPAs (as per https://github.com/qbittorrent/qBittorrent/wiki/Installing-qBittorrent) which seems like a good compromise in getting the latest features but after some testing.

sbocquet commented 3 years ago

Hi.

Thank you for the workaround. Unfortunately, I prefer building my own package. There is always some few risks to put PPAs on a Debian system. Plus I want to install it on other servers. The fact is that, by compiling the sources on my server, I'm sure it works nice with my version of my other libraries.

I was wondering how the "official" package are maid ? Any idea or tutos ?

Thanks for any help.

GvY85 commented 2 years ago

I understand your concern regarding PPA's but I gave up building the packages myself some time ago on Debian 10. The environment kept changing and breaking stuff and ~25% of my used disk space was from stuff needed to build qbittorrent-nox. So I went for the Debian nightly builds (that have a stable branch as well):

https://github.com/qbittorrent/qBittorrent/issues/12616#issuecomment-875368452

I agree, dont use a PPA on Debian,

userdocs commented 2 years ago

Since this does not actually look like qbittorrent issue but a checkinstall issue you could use github to make your own packaged releases instead, if you are adamant about creating your own release and using that. I have shown it can be done here:

https://github.com/userdocs/test/releases/tag/4.4.0beta3_2.0.4.0 https://github.com/userdocs/test/actions/runs/1249686046

Using this action:

https://github.com/userdocs/test/blob/master/.github/workflows/qbittorrent_build_and_release_v3.yml

Specifically using this: (edit, wrong url)

https://github.com/jiro4989/build-deb-action

You don't have to do a full matrix like the example and could easily create a build + deb + release in about 15 minutes using a github action.

FranciscoPombal commented 2 years ago

I recommend using CMake to build qBittorrent: https://github.com/qbittorrent/qBittorrent/wiki/Compilation:-Debian,-Ubuntu,-and-derivatives.

Moving to discussions, as this is not an issue with qBittorrent.